Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improved & fixed code sample #38776

Closed
wants to merge 4 commits into from
Closed

docs: improved & fixed code sample #38776

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
55a3ca8
directly import http
todortotev May 22, 2021
65059f4
json stringify instead of querystring.stringify
todortotev May 22, 2021
2160d1d
use single quotes and semicolons for consistency
todortotev May 23, 2021
8c5c379
application/json instead of x-www-form-urlencoded
todortotev May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2898,7 +2898,9 @@ class. The `ClientRequest` instance is a writable stream. If one needs to
upload a file with a POST request, then write to the `ClientRequest` object.

```js
const postData = querystring.stringify({
const http = require('http');

const postData = JSON.stringify({
todortotev marked this conversation as resolved.
Show resolved Hide resolved
'msg': 'Hello World!'
});

Expand All @@ -2908,7 +2910,7 @@ const options = {
path: '/upload',
method: 'POST',
headers: {
'Content-Type': 'application/x-www-form-urlencoded',
'Content-Type': 'application/json',
'Content-Length': Buffer.byteLength(postData)
}
};
Expand Down