Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(async_hooks): fix imports in context example #39229

Merged

Conversation

yashLadha
Copy link
Contributor

Fixed imports of certain packages required to run the example.

@github-actions github-actions bot added async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations. labels Jul 2, 2021
@yashLadha yashLadha force-pushed the fix_async_hooks_context_docs branch from e54ee54 to 5b91b6b Compare July 2, 2021 04:44
Copy link
Contributor

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be doing this given #38382 (comment)? cc @aduh95

@RaisinTen RaisinTen requested a review from aduh95 July 10, 2021 14:24
Added imports for packages that is mentioned in the example of
async_hooks context example.
@Flarna Flarna force-pushed the fix_async_hooks_context_docs branch from 5b91b6b to e8d2176 Compare February 3, 2022 10:38
@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0f84217 into nodejs:master Feb 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 0f84217

VoltrexKeyva pushed a commit to VoltrexKeyva/node that referenced this pull request Feb 3, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.

PR-URL: nodejs#39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.

PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.

PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.

PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
Added imports for packages that is mentioned in the example of
async_hooks context example.

PR-URL: #39229
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async_hooks Issues and PRs related to the async hooks subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants