Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.PORT instead of hardcoded port number #39298

Merged
merged 1 commit into from
Jul 10, 2021
Merged

test: use common.PORT instead of hardcoded port number #39298

merged 1 commit into from
Jul 10, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 7, 2021

No description provided.

@github-actions github-actions bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 7, 2021
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38895/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38899/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38901/

@Trott
test: use common.PORT instead of hardcoded port number
debdc1d 
PR-URL: nodejs#39298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 10, 2021

Landed in debdc1d

@Trott Trott merged commit debdc1d into nodejs:master Jul 10, 2021
@Trott Trott deleted the speed branch July 10, 2021 00:03
targos pushed a commit that referenced this pull request Jul 11, 2021
@Trott @targos
test: use common.PORT instead of hardcoded port number
0ec93a1 
PR-URL: #39298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
test: use common.PORT instead of hardcoded port number
a45bf2f 
PR-URL: #39298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @jasnell @cjihrig