Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: do not use tilde for "about" or "approximately" #39344

Merged
merged 1 commit into from
Jul 12, 2021
Merged

doc: do not use tilde for "about" or "approximately" #39344

merged 1 commit into from
Jul 12, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 10, 2021

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Jul 10, 2021
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2021
@Trott
doc: do not use tilde for "about" or "approximately"
91ec27f 
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters

PR-URL: nodejs#39344
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 12, 2021

Landed in 91ec27f

@Trott Trott merged commit 91ec27f into nodejs:master Jul 12, 2021
@Trott Trott deleted the tilde branch July 12, 2021 22:49
targos pushed a commit that referenced this pull request Jul 13, 2021
@Trott @targos
doc: do not use tilde for "about" or "approximately"
0b3b269 
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters

PR-URL: #39344
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @lpinca @tniessen @RaisinTen @targos @nodejs-github-bot