doc: security release announcement safety check #40333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This happened today: https://www.githubstatus.com/incidents/bdbzpz7qxmbx. |
mscdex
reviewed
Oct 5, 2021
| @@ -35,6 +35,8 @@ information described. | |||
|
|
|||
| ## Announcement (one week in advance of the planned release) | |||
|
|
|||
| * [ ] Verify that Github Actions are working as normal: https://www.githubstatus.com/. | |||
There was a problem hiding this comment.
Should this be in a different section? Seems like verifying this would be more of a last minute thing, not a "one week in advance" thing?
There was a problem hiding this comment.
This is actually the last minute thing. We can't publish to the website if the Github Actions are down.
tniessen
approved these changes
Oct 5, 2021
Trott
reviewed
Oct 5, 2021
24 tasks
Github Actions could have an outage and we should abort the publishing of the PR if they are.
mcollina
force-pushed
the
update-security-guide-check-outage
branch
from
fe0ae0f
to
99be55b
Compare
lpinca
approved these changes
Oct 6, 2021
25 tasks
mcollina
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40333 ✔ Done loading data for nodejs/node/pull/40333 ----------------------------------- PR info ------------------------------------ Title doc: security release announcement safety check (#40333) Author Matteo Collina (@mcollina) Branch mcollina:update-security-guide-check-outage -> nodejs:master Labels doc Commits 1 - doc: security release announcement safety check Committers 1 - Matteo Collina PR-URL: https://github.com/nodejs/node/pull/40333 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40333 Reviewed-By: Tobias Nießen Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 05 Oct 2021 15:19:55 GMT ✔ Approvals: 2 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40333#pullrequestreview-771685309 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40333#pullrequestreview-773162062 ✖ This PR needs to wait 4 more hours to land ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1315788152 |
github-actions
bot
added
the
commit-queue-failed
mcollina
removed
the
commit-queue-failed
jasnell
approved these changes
Oct 7, 2021
mcollina
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 1fc1b0f...a3bfcb0 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Github Actions could have an outage and we should abort the publishing of the PR if they are. PR-URL: #40333 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
23 tasks
danielleadams
pushed a commit
to danielleadams/node
that referenced
this pull request
Oct 8, 2021
Github Actions could have an outage and we should abort the publishing of the PR if they are. PR-URL: nodejs#40333 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Actions could have an outage and we should abort the publishing
of the PR if they are.