Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix commit-lint workflow #40673

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 31, 2021

It seems that #39128 broke something. If I understand correctly, depending on when the PR has diverged from the base branch, git may be incapable of computing the ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} commit range. Instead we can specify how many commits there are in the PR since it's an information we already have anyway.

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 31, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 31, 2021
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

PR-URL: nodejs#40673
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 1, 2021

Landed in 14825d6

@aduh95 aduh95 merged commit 14825d6 into nodejs:master Nov 1, 2021
targos pushed a commit that referenced this pull request Nov 6, 2021
PR-URL: #40673
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Nov 8, 2021
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
PR-URL: #40673
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants