Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix withoutintl builds #41078

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Dec 3, 2021

Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

Refs: #41077
Refs: #41036

Consider this a quick fix to unblock the CI as the automated tooling will attempt to update again the next time it is run. It's getting late here on a Friday evening so maybe someone else can take a look and figure out if the break is due to highlight.js or something latent in Node.js/V8.

Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Dec 3, 2021
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2021

Fast-track has been requested by @richardlau. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2021
@nodejs-github-bot
Copy link
Collaborator

@@ -7,7 +7,7 @@
"node": ">=14.8.0"
},
"devDependencies": {
"highlight.js": "^11.3.1",
"highlight.js": "^11.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You meant to pin the version, right?

Suggested change
"highlight.js": "^11.2.0",
"highlight.js": "11.2.0",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just partially undid the package updates in #41036. I think the package-lock.json takes care of it as the Makefile runs npm ci:

node/Makefile

Lines 686 to 691 in a257294

tools/doc/node_modules: tools/doc/package.json
@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
echo "Skipping tools/doc/node_modules (no crypto)"; \
else \
cd tools/doc && $(call available-node,$(run-npm-ci)) \
fi

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't start failing until #41036 was merged -- the newer highlight.js was published two months ago: https://www.npmjs.com/package/highlight.js

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 4, 2021
@nodejs-github-bot nodejs-github-bot merged commit c802c4b into nodejs:master Dec 4, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in c802c4b

@richardlau richardlau deleted the rollback branch December 4, 2021 14:53
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: nodejs#41078
Refs: nodejs#41077
Refs: nodejs#41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Recent upgrade of highlight.js has broken the docs build on the
withoutintl builds.

PR-URL: #41078
Refs: #41077
Refs: #41036
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants