Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move one or more TSC members to emeritus #41466

Closed
wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-tsc.yml.

@nodejs/tsc @RaisinTen

Since 3 months ago, RaisinTen attended 1 out of 10 meetings and voted in 0 of 2 votes.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Jan 11, 2022
@BethGriggs BethGriggs added the invalid Issues and PRs that are invalid. label Jan 11, 2022
Copy link
Member

@VoltrexKeyva VoltrexKeyva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RaisinTen was recently added as a TSC member so this one was triggered on a bad time. :^)

@mhdawson
Copy link
Member

@Trott FYI - I think the automation needs to be updated to handle people who just joined.

@Trott
Copy link
Member

Trott commented Jan 11, 2022

@Trott FYI - I think the automation needs to be updated to handle people who just joined.

It's supposed to compare the README from 3 months ago with the current README and ignore any TSC members that aren't listed in both versions of the README. Obviously, there's a bug in that code. 🙃

@Trott
Copy link
Member

Trott commented Jan 11, 2022

Here's the relevant code block:

// Get current TSC members, then get TSC members at start of period. Only check
// TSC members who are on both lists. This way, we don't flag someone who has
// only been on the TSC for a week and therefore hasn't attended any meetings.
const tscMembersAtEnd = await getTscFromReadme();

await runGitCommand(`git checkout 'HEAD@{${SINCE}}' -- README.md`);
const tscMembersAtStart = await getTscFromReadme();
await runGitCommand('git reset HEAD README.md');
await runGitCommand('git checkout -- README.md');

const tscMembers = tscMembersAtEnd.filter(
  (memberAtEnd) => tscMembersAtStart.includes(memberAtEnd)
);

I'll start debugging and figure it out later, but putting this here in case someone wants to get a jump on it and beat me to it. :-D

Trott added a commit to Trott/io.js that referenced this pull request Jan 11, 2022
@Trott
Copy link
Member

Trott commented Jan 11, 2022

I believe the problem is that the workflow is doing a shallow checkout.

Fix (I think/hope) is in #41472.

@Trott Trott closed this Jan 11, 2022
@Trott Trott deleted the actions/inactive-tsc branch January 11, 2022 07:03
nodejs-github-bot pushed a commit that referenced this pull request Jan 11, 2022
Trott added a commit that referenced this pull request Jan 11, 2022
nodejs-github-bot pushed a commit that referenced this pull request Jan 11, 2022
Trott added a commit that referenced this pull request Jan 11, 2022
Trott added a commit that referenced this pull request Jan 11, 2022
Trott added a commit to Trott/io.js that referenced this pull request Jan 11, 2022
Trott added a commit that referenced this pull request Jan 11, 2022
nodejs-github-bot pushed a commit that referenced this pull request Jan 13, 2022
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Jan 14, 2022
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
Refs: nodejs#41466

PR-URL: nodejs#41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
Refs: nodejs#41466

PR-URL: nodejs#41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Refs: nodejs#41466

PR-URL: nodejs#41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Refs: #41466

PR-URL: #41472
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. invalid Issues and PRs that are invalid. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants