Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.x backport] tools: enable no-empty ESLint rule #42160

Closed
wants to merge 8 commits into from
Closed

[16.x backport] tools: enable no-empty ESLint rule #42160

wants to merge 8 commits into from

Commits on Mar 2, 2022

  1. benchmark: enable no-empty ESLint rule 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    bf3bb92 View commit details
    Browse the repository at this point in the history

  2. doc: remove empty block from console.timeEnd() example 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a24b61a View commit details
    Browse the repository at this point in the history

  3. doc: add comments to empty blocks in worker_threads text 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    7c0cd14 View commit details
    Browse the repository at this point in the history

  4. lib: add comments to empty catch statements 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    0038697 View commit details
    Browse the repository at this point in the history

  5. policy: revise manifest.js to avoid empty blocks 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b35692f View commit details
    Browse the repository at this point in the history

  6. stream: remove empty block 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    d00c97a View commit details
    Browse the repository at this point in the history

  7. test: enable no-empty ESLint rule 

    PR-URL: nodejs#41831
Refs: https://eslint.org/docs/rules/no-empty
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    48f5a12 View commit details
    Browse the repository at this point in the history

  8. tools: enable no-empty ESLint rule 

    Refs: https://eslint.org/docs/rules/no-empty

PR-URL: nodejs#41831
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @Trott
    Trott committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    01c3818 View commit details
    Browse the repository at this point in the history