Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use serial comma in worker_threads docs #43220

Merged
merged 1 commit into from
May 28, 2022
Merged

doc: use serial comma in worker_threads docs #43220

merged 1 commit into from
May 28, 2022

Conversation

tniessen
Copy link
Member

node/doc/README.md

Line 21 in 5e9274a

* [Use serial commas][].

Refs: #11321
Refs: #17384

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels May 27, 2022
mhdawson
mhdawson approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2022
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 28, 2022
@nodejs-github-bot nodejs-github-bot merged commit ca0044b into nodejs:master May 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in ca0044b

bengl pushed a commit that referenced this pull request May 30, 2022
@tniessen @bengl
doc: use serial comma in worker_threads docs
badf72d 
Refs: #11321
Refs: #17384

PR-URL: #43220
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@bengl bengl mentioned this pull request May 31, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
doc: use serial comma in worker_threads docs
b314906 
Refs: #11321
Refs: #17384

PR-URL: #43220
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@tniessen @targos
doc: use serial comma in worker_threads docs
1a72b75 
Refs: #11321
Refs: #17384

PR-URL: #43220
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: use serial comma in worker_threads docs
7feff01 
Refs: #11321
Refs: #17384

PR-URL: #43220
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: use serial comma in worker_threads docs
e861dcb 
Refs: nodejs/node#11321
Refs: nodejs/node#17384

PR-URL: nodejs/node#43220
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@mhdawson mhdawson mhdawson approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tniessen @nodejs-github-bot @lpinca @mhdawson @VoltrexKeyva