Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test-net-error-twice #4342

Closed
wants to merge 1 commit into from

Commits on Dec 18, 2015

  1. test: fix flaky test-net-error-twice

    On Windows there can exist some race condition where the
    notification of the client's `socket.destroy()` isn't received
    before the server writes to the socket. This race condition was
    more evident/reproducible on a single core system.
    
    This commit fixes the flakiness by waiting until the server's
    connection event handler has been called to destroy the client
    socket and perform the server socket write.
    
    Fixes: nodejs#4057
    mscdex committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    34129a6 View commit details
    Browse the repository at this point in the history