src: remove forwards for v8::GC*logueCallback #4381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofrobots
added
v8 engine
|
Can you also remove them from node_counters.cc and node_lttng.cc? LGTM after that. |
These types are no longer used in the file and V8 4.9 no longer defines these types anymore. PR-URL: nodejs#4381 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
ofrobots
force-pushed
the
remove-unnecessary-forwards
branch
from
03cbf14
to
f00c080
Compare
|
Done. New CI: https://ci.nodejs.org/job/node-test-pull-request/1041/ |
ofrobots
added a commit
that referenced
this pull request
Dec 22, 2015
These types are no longer used in the file and V8 4.9 no longer defines these types anymore. PR-URL: #4381 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in 79dc1d7. |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Dec 22, 2015
These types are no longer used in the file and V8 4.9 no longer defines these types anymore. PR-URL: nodejs#4381 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
|
As this has a |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
These types are no longer used in the file and V8 4.9 no longer defines these types anymore. PR-URL: nodejs#4381 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These types are no longer used in the file and V8 4.9 no longer defines these
types anymore.
R=@bnoordhuis