Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: run license-builder #45553

Merged
merged 1 commit into from
Nov 21, 2022
Merged

doc: run license-builder #45553

merged 1 commit into from
Nov 21, 2022

Conversation

github-actions[bot]
Copy link
Contributor

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 21, 2022
@github-actions
Copy link
Contributor Author

Fast-track has been requested by @Trott. Please 👍 to approve.

@@ -1040,9 +1040,9 @@ The externally maintained libraries used by Node.js are:
- zlib, located at deps/zlib, is licensed as follows:
"""
zlib.h -- interface of the 'zlib' general purpose compression library
version 1.2.11, January 15th, 2017
version 1.2.13, October 13th, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The zlib on the main branch is still v1.2.12: b6c108f

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deps/zlib/zlib.h says 1.2.13. 🤷 deps/zlib/LICENSE says 1.2.12 though. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://chromium.googlesource.com/chromium/src/third_party/zlib indicates that 8bbd6c31 is 1.2.13, so I think this commit is correct and the zlib LICENSE file didn't get updated for the release. So I think we're good.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit abadaca into main Nov 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in abadaca

@nodejs-github-bot nodejs-github-bot deleted the actions/license-builder branch November 21, 2022 03:26
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
PR-URL: #45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
PR-URL: nodejs#45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
PR-URL: #45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
PR-URL: #45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
PR-URL: #45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
PR-URL: #45553
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants