tools: automate uvwasi dependency update #47509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
meta
Ranieri93
force-pushed
the
feat/automate-uvwasi-update
branch
2 times, most recently
from
d67fbe8
to
8d32af9
Compare
Ranieri93
force-pushed
the
feat/automate-uvwasi-update
branch
2 times, most recently
from
a44d55e
to
8bf8292
Compare
mhdawson
reviewed
Apr 11, 2023
mhdawson
reviewed
Apr 11, 2023
|
|
||
| * Copy over the contents of `include` and `src` to the corresponding | ||
| directories. | ||
| * Check if any additional files have been added and need to be added |
There was a problem hiding this comment.
Is there any way to check this in the update script and to generate a warning/info message if there are new files found?
There was a problem hiding this comment.
That’s a valid point, maybe @marco-ippolito already faced something alike in other scripts, I'll ask him!
There was a problem hiding this comment.
this is the first attempt of automating gyp file update #47482, let's see how it goes and if its reliable we can add it to other dependencies.
For the time being I'd add a warn like:
echo "Make sure to update the deps/uvwasi/uvwasi.gyp if any significant changes have occurred upstream" in the bash script
Ranieri93
force-pushed
the
feat/automate-uvwasi-update
branch
2 times, most recently
from
a5572a3
to
28d5827
Compare
Ranieri93
force-pushed
the
feat/automate-uvwasi-update
branch
from
f74bbe8
to
9563b6e
Compare
Ranieri93
force-pushed
the
feat/automate-uvwasi-update
branch
from
9563b6e
to
d39e562
Compare
RafaelGSS
approved these changes
Apr 13, 2023
|
cc: @nodejs/security-wg |
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5fa84e8 |
targos
pushed a commit
that referenced
this pull request
May 2, 2023
Refs: nodejs/security-wg#828 PR-URL: #47509 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: nodejs/security-wg#828 PR-URL: #47509 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Refs: nodejs/security-wg#828 PR-URL: nodejs#47509 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/security-wg#828