Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update github labels for benchmarks #47545

Closed
wants to merge 2 commits into from
Closed

Update github labels for benchmarks #47545

wants to merge 2 commits into from

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 13, 2023

This pull request adds 2 commits:

  1. Adds performance label to all changes inside the benchmark folder
  2. Adds url and whatwg-url label to all changes inside benchmark/url folder

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 13, 2023
@anonrig anonrig changed the title Upadte label pr config Update github labels for benchmarks Apr 13, 2023
MoLow
MoLow approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 13, 2023
@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Apr 13, 2023
@debadree25
Copy link
Member

two distinct changes i think? hence added the rebase tag

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 93e550a...5931b44

nodejs-github-bot pushed a commit that referenced this pull request Apr 15, 2023
@anonrig @nodejs-github-bot
tools: add performance label to benchmark changes
8b1c34c 
PR-URL: #47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Apr 15, 2023
@anonrig @nodejs-github-bot
tools: add url and whatwg-url labels automatically
5931b44 
PR-URL: #47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig @targos
tools: add performance label to benchmark changes
ff73c05 
PR-URL: #47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
targos pushed a commit that referenced this pull request May 2, 2023
@anonrig @targos
tools: add url and whatwg-url labels automatically
6af7f1e 
PR-URL: #47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig @danielleadams
tools: add performance label to benchmark changes
237edee 
PR-URL: #47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
@anonrig @danielleadams
tools: add url and whatwg-url labels automatically
94174b3 
PR-URL: #47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig @MoLow
tools: add performance label to benchmark changes
d5c9bc4 
PR-URL: nodejs#47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
@anonrig @MoLow
tools: add url and whatwg-url labels automatically
b6ca57e 
PR-URL: nodejs#47545
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@danielleadams danielleadams mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoLow MoLow MoLow approved these changes

@debadree25 debadree25 debadree25 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anonrig @debadree25 @nodejs-github-bot @MoLow