Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix lint error in wasi.md #47611

Merged
merged 1 commit into from
Apr 18, 2023
Merged

doc: fix lint error in wasi.md #47611

merged 1 commit into from
Apr 18, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 18, 2023

This should fix the linter error on main.

@aduh95 aduh95 marked this pull request as ready for review April 18, 2023 16:49
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. wasi Issues and PRs related to the WebAssembly System Interface. labels Apr 18, 2023
@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@aduh95 aduh95 changed the title doc: fix history ordering of WASI constructor doc: fix lint error in wasi.md Apr 18, 2023
@aduh95 @Trott
doc: fix history ordering of WASI constructor
bc445fa 
PR-URL: nodejs#47611
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott merged commit bc445fa into nodejs:main Apr 18, 2023
@Trott
Copy link
Member

Trott commented Apr 18, 2023

Landed in bc445fa

@aduh95 aduh95 deleted the wasi-doc-lint branch April 18, 2023 19:41
targos pushed a commit that referenced this pull request May 2, 2023
@aduh95 @targos
doc: fix history ordering of WASI constructor
c36634e 
PR-URL: #47611
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 2, 2023
Merged
@danielleadams danielleadams added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @Trott @lpinca @RafaelGSS @danielleadams