Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update nghttp2 to 1.54.0 #48415

Closed
wants to merge 2 commits into from
Closed

deps: update nghttp2 to 1.54.0 #48415

wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of nghttp2 to 1.54.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jun 11, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jun 11, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52203/

@github-actions github-actions bot mentioned this pull request Jun 12, 2023
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52221/

@lpinca
Copy link
Member

lpinca commented Jun 12, 2023 •
edited
Loading

I think there is something wrong with this update. See nghttp2/nghttp2@v1.53.0...v1.54.0.

@targos
Copy link
Member

targos commented Jun 12, 2023

FWIW I get the same diff with a local run of the update script.

@targos
Copy link
Member

targos commented Jun 12, 2023

There are no changes to the lib folder in nghttp2/nghttp2@v1.53.0...v1.54.0

@marco-ippolito
Copy link
Member

marco-ippolito commented Jun 12, 2023 •
edited
Loading

I guess the changes in this release are on parts of codebase are ignored by us

@lpinca
Copy link
Member

lpinca commented Jun 12, 2023

Ah, I didn't know we only track lib. It should be ok then.

This was referenced Jun 13, 2023
Open
Open
This was referenced Jun 15, 2023
Open
Open
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52403/

This was referenced Jun 24, 2023
Open
Open
Open
Open
@targos targos closed this Jul 12, 2023
@targos targos deleted the actions/tools-update-nghttp2 branch July 12, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@trivikr trivikr trivikr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nodejs-github-bot @lpinca @targos @marco-ippolito @trivikr @RafaelGSS @aduh95