Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: handle unicode hostname if empty #49396

Merged
merged 1 commit into from
Aug 31, 2023
Merged

url: handle unicode hostname if empty #49396

merged 1 commit into from
Aug 31, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 28, 2023

The original PR by @Xstoudi seems abandoned (ref: #49087)

Fixes: #48759

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 28, 2023
@cjihrig
Copy link
Contributor

cjihrig commented Aug 28, 2023

Suggestion: maintain @Xstoudi as the commit author.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2023
@anonrig anonrig requested a review from cjihrig August 29, 2023 18:41
@anonrig anonrig added the review wanted PRs that need reviews. label Aug 29, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53621/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 29, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53651/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit f863117 into nodejs:main Aug 31, 2023
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f863117

UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@anonrig @UlisesGascon
url: handle unicode hostname if empty
e787673 
PR-URL: #49396
Fixes: #48759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@anonrig @alexfernandez
url: handle unicode hostname if empty
e58fb61 
PR-URL: nodejs#49396
Fixes: nodejs#48759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2023
@anonrig @targos
url: handle unicode hostname if empty
f256b16 
PR-URL: #49396
Fixes: #48759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
url: handle unicode hostname if empty
3486a1e 
PR-URL: nodejs/node#49396
Fixes: nodejs/node#48759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
url: handle unicode hostname if empty
ae94700 
PR-URL: nodejs/node#49396
Fixes: nodejs/node#48759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WHATWG URL API format() function inserts '//' wrongly when 'unicode' is set
4 participants
@anonrig @nodejs-github-bot @cjihrig @lpinca