Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v18.x backport] test: fix flaky test-watch-mode #49468

Closed

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Sep 3, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Sep 3, 2023
PR-URL: nodejs#48147
Fixes: nodejs#44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@ruyadorno ruyadorno force-pushed the backport-deflake-watch-mode-test branch from bb79fbd to 35943c1 Compare September 7, 2023 00:17
@nodejs-github-bot
Copy link
Collaborator

@ruyadorno
Copy link
Member

Landed in 4892dc5

@ruyadorno ruyadorno closed this Sep 7, 2023
ruyadorno pushed a commit that referenced this pull request Sep 7, 2023
PR-URL: #48147
Backport-PR-URL: #49468
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MoLow MoLow deleted the backport-deflake-watch-mode-test branch September 7, 2023 16:15
ruyadorno pushed a commit that referenced this pull request Sep 13, 2023
PR-URL: #48147
Backport-PR-URL: #49468
Fixes: #44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants