Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm: improve JSDoc annotation of internal functions #49959

Merged
merged 2 commits into from
Oct 1, 2023

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 29, 2023

Extracted from #49918

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2023
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. typings and removed needs-ci PRs that need a full CI run. labels Sep 29, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@GeoffreyBooth

This comment was marked as resolved.

Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
@atlowChemi atlowChemi added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 1, 2023
@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 1, 2023
@aduh95 aduh95 merged commit aadfea4 into nodejs:main Oct 1, 2023
27 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Oct 1, 2023

Landed in aadfea4

@aduh95 aduh95 deleted the run-main-typings branch October 1, 2023 07:27
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: #49959
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs#49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs/node#49959
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: nodejs/node#49959
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 48 hours to land. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants