Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cast to v8::Value before using v8::EmbedderGraph::V8Node #52638

Merged
merged 1 commit into from
Apr 25, 2024
Merged

src: cast to v8::Value before using v8::EmbedderGraph::V8Node #52638

merged 1 commit into from
Apr 25, 2024

Commits on Apr 22, 2024

  1. src: cast to v8::Value before using v8::EmbedderGraph::V8Node 

    This is required to disambiguate the call site for an upstream
patch to support v8::Data in traced references and pass the
Node.js integration in the V8 CI. When that lands in the upstream
we can implement V8Node(const v8::Local<v8::Data>) in a
follow-up.

Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5403888
    @joyeecheung
    joyeecheung committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9842e8d View commit details
    Browse the repository at this point in the history