Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: reduce amount of caught URL errors #52658

Merged
merged 1 commit into from
Jun 13, 2024
Merged

lib: reduce amount of caught URL errors #52658

merged 1 commit into from
Jun 13, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 24, 2024

Since we have URL.parse() now, we don't need try/catch with new URL(). This will potentially improve the performance of hot paths.

cc @nodejs/url

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 24, 2024
RedYetiDev
RedYetiDev approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@RedYetiDev RedYetiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anonrig anonrig force-pushed the reduce-url-throws branch 3 times, most recently from 9cfdd53 to b0f5fed Compare April 24, 2024 02:50
aduh95
aduh95 reviewed Apr 24, 2024
View reviewed changes
lib/internal/url.js Outdated Show resolved Hide resolved
@anonrig anonrig force-pushed the reduce-url-throws branch 2 times, most recently from f85ee6c to 38be5ca Compare May 17, 2024 01:04
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59264/

@anonrig anonrig force-pushed the reduce-url-throws branch 2 times, most recently from 0cd00d8 to 935e22e Compare May 17, 2024 20:19
aduh95
aduh95 reviewed May 17, 2024
View reviewed changes
lib/internal/url.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59754/

@anonrig
Copy link
Member Author

anonrig commented Jun 13, 2024

hey @aduh95 @jasnell @targos @GeoffreyBooth can I get a review on this pull-request?

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2024
@nodejs-github-bot nodejs-github-bot merged commit 852fa55 into nodejs:main Jun 13, 2024
51 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 852fa55

targos pushed a commit that referenced this pull request Jun 20, 2024
@anonrig @targos
lib: reduce amount of caught URL errors
710cf77 
PR-URL: #52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@anonrig @EliphazBouye
lib: reduce amount of caught URL errors
8bdaf5f 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@anonrig @bmeck
lib: reduce amount of caught URL errors
4b60dda 
PR-URL: nodejs#52658
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
@targos targos mentioned this pull request Jun 25, 2024
Merged
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@RedYetiDev RedYetiDev RedYetiDev approved these changes

@lemire lemire lemire approved these changes

@jasnell jasnell jasnell approved these changes

@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

@targos targos Awaiting requested review from targos

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anonrig @nodejs-github-bot @lemire @jasnell @targos @joyeecheung @aduh95 @RedYetiDev