Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: cache synchronous module jobs before linking #52868

Closed
wants to merge 3 commits into from
Closed

module: cache synchronous module jobs before linking #52868

wants to merge 3 commits into from
+57 −14

Commits on May 7, 2024

  1. test: add common.expectRequiredModule() 

    To minimize changes if/when we change the layout of the
result returned by require(esm).
    @joyeecheung
    joyeecheung committed May 7, 2024
    Configuration menu
    Copy the full SHA
    6ea1c51 View commit details
    Browse the repository at this point in the history

  2. module: cache synchronous module jobs before linking 

    So that if there are circular dependencies in the synchronous
module graph, they could be resolved using the cached jobs.
In case linking fails and the error gets caught, reset the
cache right after linking. If it succeeds, the caller will
cache it again. Otherwise the error bubbles up to users,
and since we unset the cache for the unlinkable module
the next attempt would still fail.
    @joyeecheung
    joyeecheung committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0f4b120 View commit details
    Browse the repository at this point in the history

  3. fixup! module: cache synchronous module jobs before linking 

    Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
    @joyeecheung @anonrig
    joyeecheung and anonrig committed May 7, 2024
    Configuration menu
    Copy the full SHA
    c034992 View commit details
    Browse the repository at this point in the history