-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v20.15.0 proposal #53486
v20.15.0 proposal #53486
Commits on Jun 12, 2024
-
Revert "crypto: make timingSafeEqual faster for Uint8Array"
This reverts commit 0f784c9 because it triggers a bug in the V8 version that Node.js 20.x uses. PR-URL: #53390 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd1415c - Browse repository at this point
Copy the full SHA cd1415cView commit details
Commits on Jun 17, 2024
-
src: remove misplaced windows code under posix guard in node.cc
The V8 WebAssembly trap handler setup for Windows was incorrectly nested within a POSIX conditional compilation block in src/node.cc. This caused the related functions to be effectively non-operational on Windows. The changes involve removing the Windows-specific code from the POSIX section and correctly placing it under the WIN32 check. This fix will ensure that the intended exception handling is active on Windows builds. Fixes: #52404 Refs: #35033 PR-URL: #52545 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d02907e - Browse repository at this point
Copy the full SHA d02907eView commit details -
doc: add test_runner to subsystem
PR-URL: #52774 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ea72a5 - Browse repository at this point
Copy the full SHA 6ea72a5View commit details -
test: drop test-crypto-timing-safe-equal-benchmarks
PR-URL: #52751 Refs: #38226 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 56e19e3 - Browse repository at this point
Copy the full SHA 56e19e3View commit details -
doc: simplify copy-pasting of
branch-diff
commandsPR-URL: #52757 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9587ae9 - Browse repository at this point
Copy the full SHA 9587ae9View commit details -
This patch exposes the crc32() function from zlib to user-land. It computes a 32-bit Cyclic Redundancy Check checksum of `data`. If `value` is specified, it is used as the starting value of the checksum, otherwise, 0 is used as the starting value. ```js const zlib = require('node:zlib'); const { Buffer } = require('node:buffer'); let crc = zlib.crc32('hello'); // 907060870 crc = zlib.crc32('world', crc); // 4192936109 crc = zlib.crc32(Buffer.from('hello')); // 907060870 crc = zlib.crc32(Buffer.from('world'), crc); // 4192936109 ``` PR-URL: #52692 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5161d95 - Browse repository at this point
Copy the full SHA 5161d95View commit details -
PR-URL: #52760 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 739adf9 - Browse repository at this point
Copy the full SHA 739adf9View commit details -
string_decoder: throw an error when writing a too long buffer
Configuration menu - View commit details
-
Copy full SHA for a5f3dd1 - Browse repository at this point
Copy the full SHA a5f3dd1View commit details -
test_runner: preserve hook promise when executed twice
PR-URL: #52791 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cf817e1 - Browse repository at this point
Copy the full SHA cf817e1View commit details -
build: make simdjson a public dep in GN build
PR-URL: #52755 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 918962d - Browse repository at this point
Copy the full SHA 918962dView commit details -
util: improve
isInsideNodeModules
PR-URL: #52147 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d7eba50 - Browse repository at this point
Copy the full SHA d7eba50View commit details -
PR-URL: #52702 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8fc52b3 - Browse repository at this point
Copy the full SHA 8fc52b3View commit details -
src: only apply fix in main thread
PR-URL: #52702 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 978ee0a - Browse repository at this point
Copy the full SHA 978ee0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3b2012 - Browse repository at this point
Copy the full SHA a3b2012View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0addeb2 - Browse repository at this point
Copy the full SHA 0addeb2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b83fbf8 - Browse repository at this point
Copy the full SHA b83fbf8View commit details -
tools: specify a commit-message for V8 update workflow
PR-URL: #52844 Fixes: #50497 Refs: gr2m/create-or-update-pull-request-action#280 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 8f8fb91 - Browse repository at this point
Copy the full SHA 8f8fb91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91fadac - Browse repository at this point
Copy the full SHA 91fadacView commit details -
doc: add more definitions to GLOSSARY.md
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com> PR-URL: #52798 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 97e0fef - Browse repository at this point
Copy the full SHA 97e0fefView commit details -
build, tools: copy release assets to staging R2 bucket once built
Co-authored-by: Michaël Zasso <targos@protonmail.com> PR-URL: #51394 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5215b6f - Browse repository at this point
Copy the full SHA 5215b6fView commit details -
tools: use sccache GitHub action
Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: #52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 514f01e - Browse repository at this point
Copy the full SHA 514f01eView commit details -
test: skip some console tests on dumb terminal
This adds two more tests to be skipped on systems with only a dumb terminal. See #33165 for details. PR-URL: #37770 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 1dce5de - Browse repository at this point
Copy the full SHA 1dce5deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 16ae2b2 - Browse repository at this point
Copy the full SHA 16ae2b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2246d4f - Browse repository at this point
Copy the full SHA 2246d4fView commit details -
PR-URL: #52108 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 121ea13 - Browse repository at this point
Copy the full SHA 121ea13View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12512c3 - Browse repository at this point
Copy the full SHA 12512c3View commit details -
tools: update
gr2m/create-or-update-pull-request-action
PR-URL: #52843 Refs: https://github.com/gr2m/create-or-update-pull-request-action/releases/tag/v1.9.4 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 01eff58 - Browse repository at this point
Copy the full SHA 01eff58View commit details -
build: drop base64 dep in GN build
PR-URL: #52856 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1be8232 - Browse repository at this point
Copy the full SHA 1be8232View commit details -
tools: update lint-md-dependencies to rollup@4.17.2
PR-URL: #52836 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 403a4a7 - Browse repository at this point
Copy the full SHA 403a4a7View commit details -
console: colorize console error and warn
prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 794e450 - Browse repository at this point
Copy the full SHA 794e450View commit details -
test: add common.expectRequiredModule()
To minimize changes if/when we change the layout of the result returned by require(esm). PR-URL: #52868 Fixes: #52864 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 986bfa2 - Browse repository at this point
Copy the full SHA 986bfa2View commit details -
tools: prepare custom rules for ESLint v9
Refs: https://eslint.org/docs/latest/use/migrate-to-9.0.0 PR-URL: #52889 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 5700600 - Browse repository at this point
Copy the full SHA 5700600View commit details -
doc: add names next to release key bash commands
PR-URL: #52878 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3df3e37 - Browse repository at this point
Copy the full SHA 3df3e37View commit details -
watch: enable passthrough ipc in watch mode
PR-URL: #50890 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1ff8f31 - Browse repository at this point
Copy the full SHA 1ff8f31View commit details -
src: avoid unused variable 'error' warning
The variable is only used in DEBUG mode. Define it only in that case. PR-URL: #52886 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2dcbf18 - Browse repository at this point
Copy the full SHA 2dcbf18View commit details -
tools: support != in test status files
PR-URL: #52766 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for dce0300 - Browse repository at this point
Copy the full SHA dce0300View commit details -
tools: support max_virtual_memory test configuration
PR-URL: #52766 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for e98c305 - Browse repository at this point
Copy the full SHA e98c305View commit details -
tools: fix get_asan_state() in tools/test.py
The output of `node -p process.config.variables.asan` includes a newline character so it's never exactly "1", which means asan is always "off" for the status files. This fixes the detection by stripping whitespaces from the output. PR-URL: #52766 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d485b4 - Browse repository at this point
Copy the full SHA 9d485b4View commit details -
PR-URL: #52890 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0830b31 - Browse repository at this point
Copy the full SHA 0830b31View commit details -
doc: exclude commits with baking-for-lts
PR-URL: #52896 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1e429d1 - Browse repository at this point
Copy the full SHA 1e429d1View commit details -
test: reduce memory usage of test-worker-stdio
On systems with limited memory and that are compiled with debugging information, this particular test is causing OOM condition especially as it is run in parallel. Even when run with a stripped binary as an input, the test consumes upward of 250M RSS. By limiting the input stream to the 1M, the stream is still buffering but memory consumption is similar to other parallel tests. PR-URL: #37769 Reviewed-By: Michael Dawson <midawson@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 6001b16 - Browse repository at this point
Copy the full SHA 6001b16View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae5d47d - Browse repository at this point
Copy the full SHA ae5d47dView commit details -
doc: update fs read documentation for clarity
PR-URL: #52453 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4bf3d44 - Browse repository at this point
Copy the full SHA 4bf3d44View commit details -
build: remove deprecated calls for argument groups
Remove calls of `add_argument_group()` where an existing argument group is passed as an argument, this is deprecated since Python 3.11. PR-URL: #52913 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 48c15d0 - Browse repository at this point
Copy the full SHA 48c15d0View commit details -
test: add http agent to
executionAsyncResource
Refs: https://github.com/nodejs/node/blob/HEAD/test/async-hooks/test-async-exec-resource-http.js Signed-off-by: psj-tar-gz <lyricalllmagical@gmail.com> PR-URL: #34966 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Configuration menu - View commit details
-
Copy full SHA for 311bdc6 - Browse repository at this point
Copy the full SHA 311bdc6View commit details -
src: fix typo Unabled -> Unable
PR-URL: #52820 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b162aea - Browse repository at this point
Copy the full SHA b162aeaView commit details -
buffer: use size_t instead of uint32_t to avoid segmentation fault
Fixes: #46836 PR-URL: #48033 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 8d628c3 - Browse repository at this point
Copy the full SHA 8d628c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 585f2a2 - Browse repository at this point
Copy the full SHA 585f2a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 184cfe5 - Browse repository at this point
Copy the full SHA 184cfe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d38c2e - Browse repository at this point
Copy the full SHA 7d38c2eView commit details -
PR-URL: #44432 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0638274 - Browse repository at this point
Copy the full SHA 0638274View commit details -
test: move
test-http-server-request-timeouts-mixed
to sequentialConfiguration menu - View commit details
-
Copy full SHA for 556e9a2 - Browse repository at this point
Copy the full SHA 556e9a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3aa3337 - Browse repository at this point
Copy the full SHA 3aa3337View commit details -
doc: add examples and notes to http server.close et al
Add examples to `http` server.close, server.closeAllConnections, server.closeIdleConnections. Also add notes about usage for both server.close*Connections libraries. PR-URL: #49091 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 086626f - Browse repository at this point
Copy the full SHA 086626fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75dd009 - Browse repository at this point
Copy the full SHA 75dd009View commit details -
test: updated for each to for of in test file
PR-URL: #50308 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4102244 - Browse repository at this point
Copy the full SHA 4102244View commit details -
inspector: introduce the
--inspect-wait
flagPR-URL: #52734 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8cb1312 - Browse repository at this point
Copy the full SHA 8cb1312View commit details -
meta: move
@anonrig
to TSC regular memberPR-URL: #52932 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for d5ab1de - Browse repository at this point
Copy the full SHA d5ab1deView commit details -
deps: enable unbundling of simdjson, simdutf, ada
PR-URL: #52924 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b774544 - Browse repository at this point
Copy the full SHA b774544View commit details -
tools: add --certify-safe to nci-ci
Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #52940 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f6290bc - Browse repository at this point
Copy the full SHA f6290bcView commit details -
events: add stop propagation flag to
Event.stopImmediatePropagation
Spec mention stopImmediatePropagation should set both flags: "stop propagation" and "stop immediate propagation". So the second is not supported by Node.js as there is no hierarchy and bubbling, but the flags are both present as well as stopPropagation. It would makes sense to follow specs on that. Refs: https://dom.spec.whatwg.org/#dom-event-stopimmediatepropagation PR-URL: #39463 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 74753ed - Browse repository at this point
Copy the full SHA 74753edView commit details -
test: improve coverage of lib/readline.js
PR-URL: #38646 Refs: https://coverage.nodejs.org/coverage-16e00a15deafdad0/lib/readline.js.html#L441 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0be8123 - Browse repository at this point
Copy the full SHA 0be8123View commit details -
doc: add example for
execFileSync
method and ref to stdioAdded an example to the `execFileSync` method. This demonstrates how to handle exceptions and access the stderr and stdio properties that are attached to the `Error` object in a `catch` block. Added a link to the detailed stdio section nested under `child_process.spawn()` from each child_process sync method option description. Fixes: #39306 PR-URL: #39412 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for af27225 - Browse repository at this point
Copy the full SHA af27225View commit details -
watch: allow listening for grouped changes
PR-URL: #52722 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ae4f7e - Browse repository at this point
Copy the full SHA 4ae4f7eView commit details -
repl: fix disruptive autocomplete without inspector
Fix an issue where the autocomplete wrongly autocompletes a value from a correct value to an undefined value when `node` is built without an inspector by disabling the preview view. fixes: #40635 PR-URL: #40661 Fixes: #40635 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eceac78 - Browse repository at this point
Copy the full SHA eceac78View commit details -
test: test pipeline
end
on transform streamsAdd test that confirms that `stream.promises.pipeline(source, transform, dest, {end: false});` only skips ending the destination stream. `{end: false}` should still end any transform streams. PR-URL: #48970 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d08c9a6 - Browse repository at this point
Copy the full SHA d08c9a6View commit details -
doc: document pipeline with
end
optionThere is currently no documentation about what the `end` option in `stream.promises.pipeline` does. Refs: #40886 Refs: #34805 (comment) Fixes: #45821 PR-URL: #48970 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e62c6e2 - Browse repository at this point
Copy the full SHA e62c6e2View commit details -
src: allow preventing debug signal handler start
PR-URL: #46681 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9512839 - Browse repository at this point
Copy the full SHA 9512839View commit details -
test: replace
forEach()
intest-stream-pipe-unpipe-stream
PR-URL: #50786 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 800b6f6 - Browse repository at this point
Copy the full SHA 800b6f6View commit details -
util: fix
%s
format behavior withSymbol.toPrimitive
This commit ensures `console.log("%s", obj)` correctly invokes `obj[Symbol.toPrimitive]` for string conversion, fixing unexpected object display issue. PR-URL: #50992 Fixes: #50909 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Configuration menu - View commit details
-
Copy full SHA for 7603a51 - Browse repository at this point
Copy the full SHA 7603a51View commit details -
doc: mention push.followTags config
This has happened in v20.13.0 release. Adding this doc to prevent edge cases where the releaser will sign and push but won't be able to promote the release. PR-URL: #52906 Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be309bd - Browse repository at this point
Copy the full SHA be309bdView commit details -
stream: use
ByteLengthQueuingStrategy
when not inobjectMode
Configuration menu - View commit details
-
Copy full SHA for af29120 - Browse repository at this point
Copy the full SHA af29120View commit details -
test: fix broken env fuzzer by initializing process
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cc74bf7 - Browse repository at this point
Copy the full SHA cc74bf7View commit details -
test: add fuzzer for
ClientHelloParser
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51088 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5fb829b - Browse repository at this point
Copy the full SHA 5fb829bView commit details -
test: add fuzzer for native/js string conversion
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51120 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Configuration menu - View commit details
-
Copy full SHA for 7dda156 - Browse repository at this point
Copy the full SHA 7dda156View commit details -
cluster: replace
forEach
withfor-of
loopSigned-off-by: Jérôme Benoit <jerome.benoit@sap.com> PR-URL: #50317 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 954d2ad - Browse repository at this point
Copy the full SHA 954d2adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 033f985 - Browse repository at this point
Copy the full SHA 033f985View commit details -
events: update MaxListenersExceededWarning message log
PR-URL: #51921 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 972eafd - Browse repository at this point
Copy the full SHA 972eafdView commit details -
doc: mention quicker way to build docs
`make doc-only` skips the process of building Node, which speeds things up considerably for new contributors. PR-URL: #52937 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3a1d17a - Browse repository at this point
Copy the full SHA 3a1d17aView commit details -
test: verify request payload is uploaded consistently
Node.js seems to change how it is uploaded based on the method, but HTTP doesn't make any distinction. Co-authored-by: Austin Wright <aaa@bzfx.net> Co-authored-by: Lenvin Gonsalves <lenvingonsalves@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #34066 Refs: #27880 Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1d01325 - Browse repository at this point
Copy the full SHA 1d01325View commit details -
crypto: fix duplicated switch-case return values
PR-URL: #49030 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0fb7c18 - Browse repository at this point
Copy the full SHA 0fb7c18View commit details -
test: use
for-of
instead offorEach
PR-URL: #49790 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0513e07 - Browse repository at this point
Copy the full SHA 0513e07View commit details -
PR-URL: #52443 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8b3e83b - Browse repository at this point
Copy the full SHA 8b3e83bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 227093b - Browse repository at this point
Copy the full SHA 227093bView commit details -
test, crypto: use correct object on assert
The test case for KeyObject does not really test the creation of asymmetric cryptographic keys using jwk because of a misspelling of the variable. PR-URL: #51820 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 0c5e589 - Browse repository at this point
Copy the full SHA 0c5e589View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65fa95d - Browse repository at this point
Copy the full SHA 65fa95dView commit details -
url,tools,benchmark: replace deprecated
substr()
PR-URL: #51546 Refs: https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Global_Objects/String/substr Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be9d6f2 - Browse repository at this point
Copy the full SHA be9d6f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89a910b - Browse repository at this point
Copy the full SHA 89a910bView commit details -
doc: update hljs with the latest styles
PR-URL: #52911 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Configuration menu - View commit details
-
Copy full SHA for 2f3f2ff - Browse repository at this point
Copy the full SHA 2f3f2ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for f82d086 - Browse repository at this point
Copy the full SHA f82d086View commit details -
test_runner: fix watch mode race condition
PR-URL: #52954 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 0289a02 - Browse repository at this point
Copy the full SHA 0289a02View commit details -
- Add a step that configures Git so the update script can create commits. - Use `peter-evans/create-pull-request` as it's more maintained and correctly handles commits that are created before it runs. Refs: https://github.com/peter-evans/create-pull-request PR-URL: #52957 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for de54123 - Browse repository at this point
Copy the full SHA de54123View commit details -
doc: remove reference to AUTHORS file
PR-URL: #52960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for da4dbfc - Browse repository at this point
Copy the full SHA da4dbfcView commit details
Commits on Jun 19, 2024
-
test_runner: support test plans
Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com> PR-URL: #52860 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Configuration menu - View commit details
-
Copy full SHA for d54aa47 - Browse repository at this point
Copy the full SHA d54aa47View commit details -
cli: allow running wasm in limited vmem with --disable-wasm-trap-handler
By default, Node.js enables trap-handler-based WebAssembly bound checks. As a result, V8 does not need to insert inline bound checks int the code compiled from WebAssembly which may speedup WebAssembly execution significantly, but this optimization requires allocating a big virtual memory cage (currently 10GB). If the Node.js process does not have access to a large enough virtual memory address space due to system configurations or hardware limitations, users won't be able to run any WebAssembly that involves allocation in this virtual memory cage and will see an out-of-memory error. ```console $ ulimit -v 5000000 $ node -p "new WebAssembly.Memory({ initial: 10, maximum: 100 });" [eval]:1 new WebAssembly.Memory({ initial: 10, maximum: 100 }); ^ RangeError: WebAssembly.Memory(): could not allocate memory at [eval]:1:1 at runScriptInThisContext (node:internal/vm:209:10) at node:internal/process/execution:118:14 at [eval]-wrapper:6:24 at runScript (node:internal/process/execution:101:62) at evalScript (node:internal/process/execution:136:3) at node:internal/main/eval_string:49:3 ``` `--disable-wasm-trap-handler` disables this optimization so that users can at least run WebAssembly (with a less optimial performance) when the virtual memory address space available to their Node.js process is lower than what the V8 WebAssembly memory cage needs. PR-URL: #52766 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Configuration menu - View commit details
-
Copy full SHA for 473fa73 - Browse repository at this point
Copy the full SHA 473fa73View commit details
Commits on Jun 20, 2024
-
2024-06-20, Version 20.15.0 'Iron' (LTS)
Notable changes: doc: * add pimterry to collaborators (Tim Perry) #52874 inspector: * (SEMVER-MINOR) introduce the `--inspect-wait` flag (Kohei Ueno) #52734 test_runner: * (SEMVER-MINOR) support test plans (Colin Ihrig) #52860 tools: * (SEMVER-MINOR) fix get_asan_state() in tools/test.py (Joyee Cheung) #52766 * (SEMVER-MINOR) support max_virtual_memory test configuration (Joyee Cheung) #52766 * (SEMVER-MINOR) support != in test status files (Joyee Cheung) #52766 zlib: * (SEMVER-MINOR) expose zlib.crc32() (Joyee Cheung) #52692 PR-URL: #53486
Configuration menu - View commit details
-
Copy full SHA for 0bf200b - Browse repository at this point
Copy the full SHA 0bf200bView commit details