doc: refresh instructions for building node from source #53768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
RedYetiDev
reviewed
Jul 9, 2024
|
@trivikr this one also follows-up on improving the build docs, if you can help fast-track reviews 🙏🏽 |
trivikr
approved these changes
Jul 28, 2024
|
This PR is ready to land. @lirantal Would you like to land it by following the instructions? |
trivikr
added
the
author ready
lirantal
force-pushed
the
lirantal-doc-building-1
branch
from
38cac10
to
fe98fb3
Compare
|
@trivikr thanks, I've rebased to squash the commits now. |
- Organize the prerequisites sub-header properly - Add a note about memory limit PR-URL: nodejs#53768 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
trivikr
force-pushed
the
lirantal-doc-building-1
branch
from
fe98fb3
to
6d6f79c
Compare
trivikr
added
the
commit-queue
|
I added the metadata, and https://github.com/nodejs/node/blob/main/doc/contributing/commit-queue.md#overview |
trivikr
approved these changes
Aug 4, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in c6cf313 |
|
Thanks! |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
- Organize the prerequisites sub-header properly - Add a note about memory limit PR-URL: #53768 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 21, 2024
- Organize the prerequisites sub-header properly - Add a note about memory limit PR-URL: #53768 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
BUILDING.mddocument, helping clarify and organize some of the instructions in the sections properly and keep them up to date.