Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move spkac methods to ncrypto #53985

Closed
wants to merge 1 commit into from
Closed

src: move spkac methods to ncrypto #53985

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 21, 2024

No description provided.

@jasnell jasnell requested review from anonrig and tniessen July 21, 2024 22:59
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnell jasnell added request-ci Add this label to start a Jenkins CI on a PR. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 21, 2024
@jasnell jasnell force-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from ea5104c to 9afde2d Compare July 21, 2024 23:06
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 21, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 21, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/60518/ 💛

@jasnell jasnell added crypto Issues and PRs related to the crypto subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Jul 21, 2024
@jasnell
Copy link
Member Author

jasnell commented Jul 21, 2024

@nodejs/crypto

anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
anonrig
anonrig reviewed Jul 21, 2024
View reviewed changes
deps/ncrypto/ncrypto.cc Outdated Show resolved Hide resolved
@jasnell jasnell force-pushed the jsnell/move-crypto-spkac-to-ncrypto branch from 9afde2d to 17c1f41 Compare July 22, 2024 14:32
@jasnell jasnell requested a review from anonrig July 22, 2024 14:35
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 22, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 22, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2024 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/60542/ 💛

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2024
jasnell added a commit that referenced this pull request Aug 5, 2024
@jasnell
src: move spkac methods to ncrypto
cf21220 
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@jasnell
Copy link
Member Author

jasnell commented Aug 5, 2024

Landed in cf21220

@jasnell jasnell closed this Aug 5, 2024
targos pushed a commit that referenced this pull request Aug 14, 2024
@jasnell @targos
src: move spkac methods to ncrypto
e619133 
PR-URL: #53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@tniessen tniessen Awaiting requested review from tniessen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @anonrig @targos