Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: fix typo on quic onSessionDatagram #54064

Merged
merged 1 commit into from
Jul 29, 2024
Merged

typings: fix typo on quic onSessionDatagram #54064

merged 1 commit into from
Jul 29, 2024

Conversation

1ilsang
Copy link
Contributor

@1ilsang 1ilsang commented Jul 27, 2024

image
  • Fix wrong typo

This was referenced Jul 27, 2024
Closed
Open
H4ad
H4ad reviewed Jul 27, 2024
View reviewed changes
Copy link
Member

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change your commit message to be more clear about what are you fixing?

Something like: typings: fix typo on quic onSessionDatagram

@1ilsang
Copy link
Contributor Author

1ilsang commented Jul 27, 2024

@H4ad

Hi, d2cf2df Done.

Thanks!

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 27, 2024
@deokjinkim deokjinkim changed the title typings: fix wrong typo typings: fix typo on quic onSessionDatagram Jul 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5210cd8 into nodejs:main Jul 29, 2024
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5210cd8

targos pushed a commit that referenced this pull request Jul 30, 2024
@1ilsang @targos
typings: fix typo on quic onSessionDatagram
0e980d6 
PR-URL: #54064
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@1ilsang @RafaelGSS
typings: fix typo on quic onSessionDatagram
e8ea49b 
PR-URL: #54064
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@deokjinkim deokjinkim deokjinkim approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@1ilsang @nodejs-github-bot @lpinca @anonrig @deokjinkim @H4ad @jakecastelli @targos