Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: do not expose internal loader #54106

Merged
merged 1 commit into from
Aug 13, 2024
Merged

test_runner: do not expose internal loader #54106

merged 1 commit into from
Aug 13, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 29, 2024

Fixes: #54071

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60732/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (c852e22) to head (29a2cf1).
Report is 61 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #54106    +/-   ##
========================================
  Coverage   87.10%   87.10%            
========================================
  Files         647      648     +1     
  Lines      181733   181972   +239     
  Branches    34886    34919    +33     
========================================
+ Hits       158291   158511   +220     
- Misses      16746    16760    +14     
- Partials     6696     6701     +5
Files Coverage Δ
lib/internal/modules/esm/hooks.js 83.72% <100.00%> (+0.04%) ⬆️
lib/internal/modules/esm/loader.js 97.76% <100.00%> (+<0.01%) ⬆️
lib/internal/test_runner/mock/loader.js 96.13% <ø> (ø)
lib/internal/test_runner/mock/mock.js 99.24% <100.00%> (+<0.01%) ⬆️

... and 24 files with indirect coverage changes

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 31, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60765/

cjihrig
cjihrig reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a lib/internal/test_runner/mock directory. Could you rename the loader into that directory please.

Would you mind removing this comment as well.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60926/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61056/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61060/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61075/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 13, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/54106
✔  Done loading data for nodejs/node/pull/54106
----------------------------------- PR info ------------------------------------
Title      test_runner: do not expose internal loader (#54106)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:mmock_loader-internal -> nodejs:main
Labels     author ready, needs-ci, test_runner
Commits    1
 - test_runner: do not expose internal loader
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/54106
Fixes: https://github.com/nodejs/node/issues/54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54106
Fixes: https://github.com/nodejs/node/issues/54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test_runner: do not expose internal loader
   ℹ  This PR was created on Mon, 29 Jul 2024 21:19:22 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54106#pullrequestreview-2206202879
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54106#pullrequestreview-2214824107
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-08-13T08:54:19Z: https://ci.nodejs.org/job/node-test-pull-request/61075/
- Querying data for job/node-test-pull-request/61075/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10367787099

@aduh95 aduh95 merged commit d0f5943 into nodejs:main Aug 13, 2024
55 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Aug 13, 2024

Landed in d0f5943

targos pushed a commit that referenced this pull request Aug 14, 2024
@aduh95 @targos
test_runner: do not expose internal loader
e8b4768 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Aug 14, 2024
@aduh95 @targos
test_runner: do not expose internal loader
fe793a6 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
targos pushed a commit that referenced this pull request Sep 21, 2024
@aduh95 @targos
test_runner: do not expose internal loader
9fcad9e 
PR-URL: #54106
Fixes: #54071
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig left review comments

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/mock_loader module exposed without node: prefix
5 participants
@aduh95 @nodejs-github-bot @benjamingr @cjihrig @MoLow