-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: add find pyenv path on windows #54314
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:feat/support-pyenv
Aug 13, 2024
Merged
tools: add find pyenv path on windows #54314
nodejs-github-bot
merged 1 commit into
nodejs:main
from
marco-ippolito:feat/support-pyenv
Aug 13, 2024
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
install
Issues and PRs related to the installers.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
windows
Issues and PRs related to the Windows platform.
labels
Aug 11, 2024
anonrig
approved these changes
Aug 11, 2024
cc @nodejs/platform-windows |
jasnell
approved these changes
Aug 11, 2024
marco-ippolito
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Aug 12, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 12, 2024
legendecas
requested changes
Aug 12, 2024
marco-ippolito
force-pushed
the
feat/support-pyenv
branch
from
August 12, 2024 10:05
e913551
to
6e65a2d
Compare
marco-ippolito
force-pushed
the
feat/support-pyenv
branch
from
August 12, 2024 10:06
6e65a2d
to
9b35ea5
Compare
legendecas
approved these changes
Aug 12, 2024
marco-ippolito
added
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 12, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 12, 2024
marco-ippolito
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 13, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 13, 2024
Landed in 9e8cc29 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54314 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54314 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Sep 21, 2024
PR-URL: #54314 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
install
Issues and PRs related to the installers.
needs-ci
PRs that need a full CI run.
tools
Issues and PRs related to the tools directory.
windows
Issues and PRs related to the Windows platform.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps a lot pyenv users on windows. (like myself)