test_runner: account for newline in source maps #54444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54444 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 648 648
Lines 182359 182359
Branches 34981 34983 +2
=======================================
Hits 159239 159239
+ Misses 16386 16384 -2
- Partials 6734 6736 +2
|
jakecastelli
approved these changes
Aug 19, 2024
github-actions
bot
removed
the
request-ci
|
FWIW @yume-chan appears to send their commits as |
benjamingr
approved these changes
Aug 19, 2024
This commit updates the source mapping logic in the test runner to account for newline characters that are not included in line length calculations. Co-authored-by: Simon Chan <1330321+yume-chan@users.noreply.github.com> Fixes: nodejs#54240
|
Thanks @RedYetiDev |
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Aug 20, 2024
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 821ffab |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
This commit updates the source mapping logic in the test runner to account for newline characters that are not included in line length calculations. Co-authored-by: Simon Chan <1330321+yume-chan@users.noreply.github.com> Fixes: #54240 PR-URL: #54444 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the source mapping logic in the test runner to account for newline characters that are not included in line length calculations.
Fixes: #54240
@yume-chan would you like to be included as a coauthor on this PR? I added the Co-authored-by metadata, but I don't know what email address you'd like to use in it.