Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-tls-client-auth test for OpenSSL32 #54610

Closed
wants to merge 2 commits into from
Closed

test: fix test-tls-client-auth test for OpenSSL32 #54610

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

Refs: #53382
Refs: #53384

Same change as in 53384 where OpenSSL32 returns a slightly different error but for a different test.

@mhdawson
test: fix test-tls-client-auth test for OpenSSL32
96ecf62 
Refs: nodejs#53382
Refs: nodejs#53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 28, 2024
@mhdawson
Copy link
Member Author

Run on OpenSSL32 - https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/33/

richardlau
richardlau approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is an observation and non-blocking.

test/parallel/test-tls-client-auth.js Outdated Show resolved Hide resolved
@richardlau richardlau mentioned this pull request Aug 28, 2024
Open
26 tasks
@richardlau
Copy link
Member

Run on OpenSSL32 - https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/33/

Looks like test is still failing, this time due to key size: https://ci.nodejs.org/job/richardlau-node-test-commit-linux-containered/33/nodes=ubuntu2204_sharedlibs_openssl32_x64/testReport/junit/(root)/parallel/test_tls_client_auth/

@richardlau richardlau added the openssl Issues and PRs related to the OpenSSL dependency. label Aug 28, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.33%. Comparing base (4f14eb1) to head (3872ec1).
Report is 28 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54610      +/-   ##
==========================================
- Coverage   87.34%   87.33%   -0.01%     
==========================================
  Files         649      649              
  Lines      182562   182562              
  Branches    35023    35029       +6     
==========================================
- Hits       159451   159446       -5     
+ Misses      16396    16383      -13     
- Partials     6715     6733      +18

see 31 files with indirect coverage changes

@mhdawson
Copy link
Member Author

@richardlau I'm hoping that the CA key too small will be fixed by my other PR so this one should still land.

@mhdawson @richardlau
Update test/parallel/test-tls-client-auth.js
3872ec1 
Co-authored-by: Richard Lau <rlau@redhat.com>
@richardlau
Copy link
Member

@richardlau I'm hoping that the CA key too small will be fixed by my other PR so this one should still land.

Ok. It'll need a clean CI, so we land the other one and then rebase this on top.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61662/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61709/

mhdawson added a commit that referenced this pull request Aug 30, 2024
@mhdawson
test: fix test-tls-client-auth test for OpenSSL32
e9cd476 
Refs: #53382
Refs: #53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54610
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
Copy link
Member Author

Landed in e9cd476

@mhdawson mhdawson closed this Aug 30, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@mhdawson @RafaelGSS
test: fix test-tls-client-auth test for OpenSSL32
53a84a3 
Refs: #53382
Refs: #53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54610
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@mhdawson @RafaelGSS
test: fix test-tls-client-auth test for OpenSSL32
e6ad355 
Refs: #53382
Refs: #53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54610
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@mhdawson @RafaelGSS
test: fix test-tls-client-auth test for OpenSSL32
7d47774 
Refs: #53382
Refs: #53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54610
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
Merged
sendoru pushed a commit to sendoru/node that referenced this pull request Sep 1, 2024
@mhdawson @sendoru
test: fix test-tls-client-auth test for OpenSSL32
096a4c1 
Refs: nodejs#53382
Refs: nodejs#53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#54610
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 1, 2024
@mhdawson @RafaelGSS
test: fix test-tls-client-auth test for OpenSSL32
a4a6ef8 
Refs: #53382
Refs: #53384

Same change as in 53384 where OpenSSL32 returns a slightly
different error but for a different test.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54610
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhdawson @richardlau @nodejs-github-bot @lpinca