Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add documentation for process.features #54897

Merged
merged 1 commit into from
Sep 14, 2024
Merged

doc: add documentation for process.features #54897

merged 1 commit into from
Sep 14, 2024

Conversation

marco-ippolito
Copy link
Member

Documenting process.features.

Refs: #54295

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 12, 2024
@marco-ippolito marco-ippolito force-pushed the fix/document-process-features branch 3 times, most recently from 95d9102 to 26cf87c Compare September 12, 2024 10:14
aduh95
aduh95 reviewed Sep 12, 2024
View reviewed changes
doc/api/process.md
## `process.features.cached_builtins`

<!-- YAML
added: REPLACEME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#27311

Suggested change
added: REPLACEME
added: v12.0.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand, why were all these suggestions resolved but not applied?

Copy link
Member Author

@marco-ippolito marco-ippolito Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see I have overwritten the commit with the suggestions with a rebase, probably not updated the remote and force pushed https://github.com/nodejs/node/compare/15d260e6bef2c00f1ca9ef84fa361a551d82976e..e3f91db3ae988513599915ad8f6e73068f2bb0da

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #54982 to fix this.

doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
doc/api/process.md Show resolved Hide resolved
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 12, 2024
@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2024
@RedYetiDev RedYetiDev mentioned this pull request Sep 12, 2024
Open
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 14, 2024
@nodejs-github-bot nodejs-github-bot merged commit cb20c5b into nodejs:main Sep 14, 2024
14 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cb20c5b

RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@marco-ippolito @RafaelGSS
doc: add documentation for process.features
be76984 
PR-URL: #54897
Refs: #54295
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@marco-ippolito @RafaelGSS
doc: add documentation for process.features
33e9610 
PR-URL: #54897
Refs: #54295
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@marco-ippolito @RafaelGSS
doc: add documentation for process.features
198071e 
PR-URL: #54897
Refs: #54295
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@aduh95 aduh95 aduh95 approved these changes

@legendecas legendecas legendecas approved these changes

@trivikr trivikr trivikr approved these changes

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@marco-ippolito @nodejs-github-bot @targos @legendecas @aduh95 @trivikr @Ethan-Arrowood @lpinca @RedYetiDev