test_runner: report error on missing sourcemap source #55037
+46
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
errors
RedYetiDev
commented
Sep 21, 2024
| '# index.ts | 100.00 | 100.00 | 100.00 | ', | ||
| '# ------------------------------------------------------------------', | ||
| '# all files | 100.00 | 100.00 | 100.00 | ', | ||
| '# ------------------------------------------------------------------', |
There was a problem hiding this comment.
Review note
I moved source-map-line-lengths into source-map/line-lengths, hence this change.
RedYetiDev
added
coverage
Fixes nodejs#54756 Co-Authored-By: Colin Ihrig <cjihrig@gmail.com> Co-Authored-By: Jayden Seric <me@jaydenseric.com>
RedYetiDev
force-pushed
the
fix-coverage-sourcemap-missing-source
branch
from
3723a8d
to
4badc52
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55037 +/- ##
==========================================
- Coverage 88.23% 88.23% -0.01%
==========================================
Files 652 652
Lines 183855 183864 +9
Branches 35856 35855 -1
==========================================
+ Hits 162227 162230 +3
- Misses 14909 14914 +5
- Partials 6719 6720 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54756
ERR_SOURCE_MAP_MISSING_SOURCEis now thrown when a sourcemap contains a reference to a non-existent file.@jaydenseric provided the test fixture, and @cjihrig provided the initial patch.