Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix test-net-settimeout flakiness #6166

Merged
merged 1 commit into from
Apr 19, 2016
Merged

test: fix test-net-settimeout flakiness #6166

merged 1 commit into from
Apr 19, 2016

Conversation

santigimeno
Copy link
Member

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) ECONNRESET
error can be avoided.

Failure in CI: https://ci.nodejs.org/job/node-test-binary-arm/RUN_SUBSET=6,nodes=pi1-raspbian-wheezy/1686/

1) test-net-settimeout.js
----------------------------------------------
# events.js:154
#       throw er; // Unhandled 'error' event
#       ^
# 
# Error: read ECONNRESET
#     at exports._errnoException (util.js:893:11)
#     at TCP.onread (net.js:550:26)

==============================================

@jasnell jasnell added the test Issues and PRs related to the tests. label Apr 12, 2016
@benjamingr
Copy link
Member

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Apr 12, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2302/

@santigimeno
test: fix test-net-settimeout flakiness
bf22c71 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: nodejs#6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@santigimeno
Copy link
Member Author

Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/2313/

@santigimeno santigimeno merged commit bf22c71 into nodejs:master Apr 19, 2016
@santigimeno santigimeno deleted the fix_test_net_settimeout branch April 19, 2016 08:07
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@santigimeno
test: fix test-net-settimeout flakiness
8003e34 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@santigimeno
test: fix test-net-settimeout flakiness
db7a907 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 20, 2016
@santigimeno @Trott
test: fix test-net-settimeout flakiness
d9367eb 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: nodejs#6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@santigimeno
test: fix test-net-settimeout flakiness
744fe56 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@santigimeno
test: fix test-net-settimeout flakiness
be993fc 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@santigimeno @MylesBorins
test: fix test-net-settimeout flakiness
68c3283 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@santigimeno @joelostrowski
test: fix test-net-settimeout flakiness
89815fd 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: nodejs#6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@santigimeno @jasnell
test: fix test-net-settimeout flakiness
8330fa4 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
@santigimeno
test: fix test-net-settimeout flakiness
27df529 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@santigimeno
test: fix test-net-settimeout flakiness
37cc249 
Wait for the data to be received by the socket before creating the
clean-up timer. This way, a possible (though unlikely) `ECONNRESET`
error can be avoided.

PR-URL: #6166
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@santigimeno @benjamingr @jasnell @MylesBorins