Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] errors: add internal/errors module #6573

Closed
wants to merge 1 commit into from

Commits on May 10, 2016

  1. errors: add internal/errors module

    This is step one to making it so that changes to error messages
    are not forced to be semver-major changes any more. The internal
    errors.js module creates three custom error class instances that
    use an assigned static error code to look up the error message.
    The message itself can change but the error code would remain the
    same. Changes to error code would still be considered semver-major,
    but changes to the messages themselves would not be.
    
    This also updates the Error objects created in lib/internal to use
    the new mechanism, changing and streamlining several of the error
    messages in the process. Obviously, this is a semver-major change
    on it's own.
    
    Several test cases were also modified and a new common.throws
    method added to test/common.js that understands the new code
    mechanism. This is added common.js so that the existing assert
    module api is unchanged.
    jasnell committed May 10, 2016
    Configuration menu
    Copy the full SHA
    7a1b47f View commit details
    Browse the repository at this point in the history