doc: mark class should have a reasonable contrast ratio #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mark class coupled with the opacity applied from the header span makes it hard to see the hashtag next to each header. I only knew the hashtag's existed after running an accesibility audit tool[1] on the page. I used a contrast checker[2] to figure out which color to use. [1]:https://github.com/GoogleChrome/accessibility-developer-tools [2]:http://webaim.org/resources/contrastchecker/
chrisdickinson
pushed a commit
that referenced
this pull request
Feb 12, 2015
PR-URL: #824 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
Thanks! Merged in 789ff95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mark class coupled with the opacity applied from the header span makes it hard to see the hashtag next to each header.
I only knew the hashtag's existed after running an accessibility audit tool on the page. I used a contrast checker to figure out which color to use.