Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move module out of fixture directory #9022

Closed
wants to merge 1 commit into from
Closed

test: move module out of fixture directory #9022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/parallel/test-tick-processor-builtin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
const common = require('../common');
const path = require('path');

if (common.isWindows ||
common.isSunOS ||
Expand All @@ -16,7 +15,7 @@ if (!common.enoughTestCpu) {
return;
}

const base = require(path.join(common.fixturesDir, 'tick-processor-base.js'));
const base = require('./tick-processor-base.js');

base.runTest({
pattern: /Builtin_DateNow/,
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-tick-processor-cpp-core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
const common = require('../common');
const path = require('path');

if (common.isWindows ||
common.isSunOS ||
Expand All @@ -16,7 +15,7 @@ if (!common.enoughTestCpu) {
return;
}

const base = require(path.join(common.fixturesDir, 'tick-processor-base.js'));
const base = require('./tick-processor-base.js');

base.runTest({
pattern: /RunInDebugContext/,
Expand Down
3 changes: 1 addition & 2 deletions test/parallel/test-tick-processor-unknown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use strict';
const common = require('../common');
const path = require('path');

// TODO(mhdawson) Currently the test-tick-processor functionality in V8
// depends on addresses being smaller than a full 64 bits. Aix supports
Expand All @@ -17,7 +16,7 @@ if (!common.enoughTestCpu) {
return;
}

const base = require(path.join(common.fixturesDir, 'tick-processor-base.js'));
const base = require('./tick-processor-base.js');

// Unknown checked for to prevent flakiness, if pattern is not found,
// then a large number of unknown ticks should be present
Expand Down
4 changes: 2 additions & 2 deletions test/fixtures/tick-processor-base.js → test/parallel/tick-processor-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ function runTest(test) {
});

let ticks = '';
proc.stdout.on('data', chunk => ticks += chunk);
proc.stdout.on('data', (chunk) => ticks += chunk);

// Try to match after timeout
setTimeout(() => {
Expand All @@ -41,7 +41,7 @@ function match(pattern, parent, ticks) {
});

let out = '';
proc.stdout.on('data', chunk => out += chunk);
proc.stdout.on('data', (chunk) => out += chunk);
proc.stdout.once('end', () => {
proc.once('exit', () => {
fs.unlinkSync(LOG_FILE);
Expand Down