doc: add more internal links to fs.Stats object #9345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
cjihrig
approved these changes
Oct 28, 2016
| @@ -867,7 +867,7 @@ added: v0.1.95 | |||
| * `callback` {Function} | |||
|
|
|||
| Asynchronous fstat(2). The callback gets two arguments `(err, stats)` where | |||
| `stats` is a [`fs.Stats`][] object. `fstat()` is identical to [`stat()`][], | |||
| `stats` is an [`fs.Stats`][] object. `fstat()` is identical to [`stat()`][], | |||
There was a problem hiding this comment.
The a -> an seems unrelated to the rest of the PR.
There was a problem hiding this comment.
Yeah, just split this to a separate commit in this PR.
|
The second commit's message is too long. Other than that, LGTM. |
lpinca
approved these changes
Nov 1, 2016
silverwind
approved these changes
Nov 1, 2016
silverwind
pushed a commit
that referenced
this pull request
Nov 1, 2016
PR-URL: #9345 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
silverwind
pushed a commit
that referenced
this pull request
Nov 1, 2016
PR-URL: #9345 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
PR-URL: #9345 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
PR-URL: #9345 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9345 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9345 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Added a few internal links, so when you're reading the documentation a method like
fs.statyou can easily click to jump to theStatsobject documentation without having to search for it in the page.Also made a few minor wording improvements for readability.