Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Added check for already defined macro NOMINMAX #986

Closed
wants to merge 1 commit into from

Conversation

pmed
Copy link
Contributor

@pmed pmed commented Feb 27, 2015

In order to avoid Visual C++ warning C4005 about macro redefinition when node.h is included in other project.

In order to avoid Visual C++ warning C4005 about macro redefinition when node.h is included in other project.
bnoordhuis pushed a commit that referenced this pull request Feb 27, 2015
In order to avoid Visual C++ warning C4005 about macro redefinition
when node.h is included in another project.

PR-URL: #986
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bnoordhuis
Copy link
Member

Thanks Pavel, landed in 4d1fa2c with an amended commit log.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants