doc: rename writing_tests.md to writing-tests.md #9867
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Dec 1, 2016
|
There were no changes to case in this PR, commit message should be
|
Change was from snake_case to kebab-case. But yeah, "casing" ambiguous and your more explicit suggestion is better. |
|
Probably not a big deal, but this will break links to the doc from at least a couple other GitHub issues. |
The writing_tests.md file did not utilize snake-case as the other files in the directory did.
captainsafia
force-pushed
the
fix-writing-tests-casing
branch
from
f1588ad
to
d5a0351
Compare
Fixed!
True. Although only 3 instances from what I could find so not too bad... |
captainsafia
changed the title
Fishrock123
approved these changes
Dec 2, 2016
targos
approved these changes
Dec 3, 2016
|
Landed in 947baaf |
targos
pushed a commit
that referenced
this pull request
Dec 3, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: #9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: #9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: nodejs#9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: #9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: #9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: #9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The writing_tests.md file did not utilize kebab-case as the other files in the directory did. PR-URL: #9867 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
The writing_tests.md file did not utilize snake-case as the other files
in the directory did.