Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internationalization): Add Russian language to Home page #6866

Closed
wants to merge 1 commit into from

Conversation

mirasayon
Copy link

@mirasayon mirasayon commented Jun 27, 2024

Description

Add Russian language to home page.

Validation

I dont know what is that. This is my first pull request 🤷‍♂️

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@mirasayon mirasayon requested a review from a team as a code owner June 27, 2024 14:58
Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 27, 2024 3:00pm

@mikeesto
Copy link
Member

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

@mirasayon
Copy link
Author

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

@ovflowd
Copy link
Member

ovflowd commented Jun 28, 2024

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

@mirasayon
Copy link
Author

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

Okay, okay. But bro, I’ve been waiting for 2 days already, I haven’t been accepted onto that platform yet. 🤷‍♂️

@ovflowd
Copy link
Member

ovflowd commented Jun 28, 2024

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

Okay, okay. But bro, I’ve been waiting for 2 days already, I haven’t been accepted onto that platform yet. 🤷‍♂️

So you sent a request to be added there already? Let me check on that. Unfortunately we don't get notifications when someone requests to join.

@mirasayon
Copy link
Author

Thanks for your first PR. The translation effort happens on Crownin, please have a look here if you would like to contribute

What? I didn't want to wait for the moderators to take me there. And what about this PR. Well, I tried my best. Can't you just merge this? Then I will do it on the Crowdin platform.

No, we can't just merge this. There are processes for translating the website and certain triggers that are generated by Crowdin. Not to mention there are proofreaders who validate the translations.

Apologies for the wasted effort, but we have it written within the README the translation guidelines 👀 and a dedicated file named TRANSLATING.md

Okay, okay. But bro, I’ve been waiting for 2 days already, I haven’t been accepted onto that platform yet. 🤷‍♂️

So you sent a request to be added there already? Let me check on that. Unfortunately we don't get notifications when someone requests to join.

Yes. Ok

@mirasayon mirasayon closed this Jun 28, 2024
@bmuenzenmeyer
Copy link
Collaborator

sorry - i check crowdin nearly every day and missed those notifications coming in

@mirasayon
Copy link
Author

sorry - i check crowdin nearly every day and missed those notifications coming in

No problem, bro, better tell me when my translation will be approved and Russian will be added to the pages.

@bmuenzenmeyer
Copy link
Collaborator

russian is 100% translated but requires proofreading. no crowdin members currently have that role - though one person expressed some interest in tag teaming it. can you help out with proofreading?

@mirasayon
Copy link
Author

russian is 100% translated but requires proofreading. no crowdin members currently have that role - though one person expressed some interest in tag teaming it. can you help out with proofreading?

Yes, sure. But I can't check all the translations at once. Is it possible to do this step by step? And gradually add Russian to the pages, starting from the home page, and not all at once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants