-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the release script work with the new changelog structure #739
Conversation
@nodejs/release if someone does a release before this lands you might want to check it out and give it a try |
|
||
return sendRequest({ | ||
url: `https://raw.githubusercontent.com/nodejs/node/master/doc/changelogs/CHANGELOG_V${ | ||
parts[0] === '0' ? parts.slice(0, 2).join('') : parts[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be extracted into a descriptive variable to increase readability?
Sorry for not reviewing this earlier! Other than my inline comments, SGTM. Would have been nice to get it tested and confirmed by someone in @nodejs/release before merging it though. |
I'll address the comments tomorrow. |
Updated. |
LGTM. I tested it with the latest versions from each release lines, seems to be working perfectly 👍 |
This updates the
release-post
script to make it work with the new changelog structure.It currently only works with:
CHANGELOG_V0{10,12}.md
CHANGELOG_V{4,5,6}.md