Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: implement Headers#set correctly #2432

Merged
merged 4 commits into from
Nov 14, 2023
Merged

fix: implement Headers#set correctly #2432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91cac31
fix: implement `Headers#set` correctly
tsctx Nov 13, 2023
ea135c8
fix: HeadersList
tsctx Nov 13, 2023
013d1e9
test: add
tsctx Nov 13, 2023
2faa129
test: fix
tsctx Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/fetch/headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ class HeadersList {
// the first such header to value and remove the
// others.
// 2. Otherwise, append header (name, value) to list.
return this[kHeadersMap].set(lowercaseName, { name, value })
this[kHeadersMap].set(lowercaseName, { name, value })
}

// https://fetch.spec.whatwg.org/#concept-header-list-delete
Expand Down Expand Up @@ -401,7 +401,7 @@ class Headers {
// 7. Set (name, value) in this’s header list.
// 8. If this’s guard is "request-no-cors", then remove
// privileged no-CORS request headers from this
return this[kHeadersList].set(name, value)
this[kHeadersList].set(name, value)
}

// https://fetch.spec.whatwg.org/#dom-headers-getsetcookie
Expand Down
12 changes: 11 additions & 1 deletion test/fetch/headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ tap.test('Headers has', t => {
})

tap.test('Headers set', t => {
t.plan(4)
t.plan(5)

t.test('sets valid header entry to instance', t => {
t.plan(2)
Expand Down Expand Up @@ -294,6 +294,16 @@ tap.test('Headers set', t => {
t.throws(() => headers.set('undici'), 'throws on missing value')
t.throws(() => headers.set('invalid @ header ? name', 'valid value'), 'throws on invalid name')
})

// https://github.com/nodejs/undici/issues/2431
t.test('`Headers#set` returns undefined', t => {
t.plan(2)
const headers = new Headers()

t.same(headers.set('a', 'b'), undefined)

t.notOk(headers.set('c', 'd') instanceof Map)
})
})

tap.test('Headers forEach', t => {
Expand Down
Loading