Fix for Max Stack Depth issue #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdmarshall
force-pushed
the
stackoverflow
branch
from
2658da8
to
75d1dee
Compare
Pull Request Test Coverage Report for Build 6659921648
💛 - Coveralls |
jdmarshall
force-pushed
the
stackoverflow
branch
from
75d1dee
to
868e786
Compare
lholmquist
reviewed
Nov 6, 2023
| @@ -106,7 +106,9 @@ class Status extends EventEmitter { | |||
| }); | |||
|
|
|||
| if (this.rollingPercentilesEnabled) { | |||
| acc.latencyTimes.push.apply(acc.latencyTimes, val.latencyTimes || []); | |||
There was a problem hiding this comment.
I had to go all the way back to this comment to remember why i did that in the first place, #55 (comment)
🤣
lholmquist
approved these changes
Nov 6, 2023
lholmquist
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
@jdmarshall thanks for stating with it and figuring this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#827 should stop with this change.