Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect key size with 0 length keySize var #89

Merged
merged 2 commits into from
May 24, 2024

Conversation

UserJHansen
Copy link
Contributor

I have found several ppt samples which don't have a proper keySize set.

Since 0 is an incorrect key size this change increases the chance that the file will still be readable.

I have found several pptx samples which don't have a proper keySize set.

Since 0 is an incorrect key size this change increases the chance that the file will still be readable.
@nolze
Copy link
Owner

nolze commented May 23, 2024

Thank you so much for identifying this tricky issue!
I found that your observation aligns with the RC4 CryptoAPI Encryption specification: RC4 CryptoAPI Encryption.
I've made some updates to your commit based on this specification. I would appreciate it if you could verify that the updated code works with your ppt samples before we proceed with the merge.

@UserJHansen
Copy link
Contributor Author

Yes, this correctly decrypts them

@nolze nolze merged commit f9c9e1a into nolze:master May 24, 2024
14 checks passed
@nolze
Copy link
Owner

nolze commented May 24, 2024

Great! Thank you again for your contribution. d6832ff

@nolze nolze removed the in progress label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants