[DataPoints] Added check to prevent unsigned int underflow in getEuclideanDim() #414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on deserialization of sensor_msgs/PointCloud2 to DataPoints I noticed that the function DataPoints::getEuclideanDim() can return very high values when the point cloud is empty. This happens due to unsigned type underflow.
I added a ternary expression that checks if the number of features is 0, and based on that returns 0 or the number of features minus 1.