Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency sanitize-html to v2 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mend-for-github-com[bot]
Copy link

@mend-for-github-com mend-for-github-com bot commented Jul 4, 2024

This PR contains the following updates:

Package Type Update Change
sanitize-html dependencies major 1.4.2 -> 2.12.1

By merging this PR, the issue #9 will be automatically resolved and closed:

Severity CVSS Score CVE
Critical Critical 9.1 CVE-2019-10744
High High 7.4 CVE-2020-8203
High High 7.2 CVE-2021-23337
Medium Medium 6.5 CVE-2018-3721
Medium Medium 6.5 CVE-2019-1010266
Medium Medium 6.1 CVE-2016-1000237
Medium Medium 6.1 CVE-2017-16016
Medium Medium 5.6 CVE-2018-16487
Medium Medium 5.3 CVE-2020-28500
Medium Medium 5.3 CVE-2021-26539
Medium Medium 5.3 CVE-2021-26540
Medium Medium 5.3 CVE-2022-25887
Medium Medium 5.3 CVE-2024-21501

Release Notes

apostrophecms/sanitize-html (sanitize-html)

v2.12.1

Compare Source

  • Do not parse sourcemaps in post-css. This fixes a vulnerability in which information about the existence or non-existence of files on a server could be disclosed via properly crafted HTML input when the style attribute is allowed by the configuration. Thanks to the Snyk Security team for the disclosure and to Dylan Armstrong for the fix.

v2.12.0

Compare Source

  • Introduced the allowedEmptyAttributes option, enabling explicit specification of empty string values for select attributes, with the default attribute set to alt. Thanks to Na for the contribution.

  • Clarified the use of SVGs with a new test and changes to documentation. Thanks to Gauav Kumar for the contribution.

  • Do not process source maps when processing style tags with PostCSS.

v2.11.0

Compare Source

  • Fix to allow false in allowedClasses attributes. Thanks to Kevin Jiang for this fix!
  • Upgrade mocha version
  • Apply small linter fixes in tests
  • Add .idea temp files to .gitignore
  • Thanks to Vitalii Shpital for the updates!
  • Show parseStyleAttributes warning in browser only. Thanks to mog422 for this update!
  • Remove empty non-boolean attributes via an exhaustive, configurable list of known non-boolean attributes. Thanks to Dylan Armstrong for this update!

v2.10.0

Compare Source

  • Fix auto-adding escaped closing tags. In other words, do not add implied closing tags to disallowed tags when disallowedTagMode is set to any variant of escape -- just escape the disallowed tags that are present. This fixes issue #​464. Thanks to Daniel Liebner
  • Add tagAllowed() helper function which takes a tag name and checks it against options.allowedTags and returns true if the tag is allowed and false if it is not.

v2.9.0

Compare Source

v2.8.1

Compare Source

  • If the argument is a number, convert it to a string, for backwards compatibility. Thanks to Alexander Schranz.

v2.8.0

Compare Source

  • Upgrades htmlparser2 to new major version ^8.0.0. Thanks to Kedar Chandrayan for this contribution.

v2.7.3

Compare Source

  • If allowedTags is falsy but not exactly false, then do not assume that all tags are allowed. Rather, allow no tags in this case, to be on the safe side. This matches the existing documentation and fixes issue #​176. Thanks to Kedar Chandrayan for the fix.

v2.7.2

Compare Source

  • Closing tags must agree with opening tags. This fixes issue #​549, in which closing tags not associated with any permitted opening tag could be passed through. No known exploit exists, but it's better not to permit this. Thanks to
    Kedar Chandrayan for the report and the fix.

v2.7.1

Compare Source

  • Protocol-relative URLs are properly supported for script tags. Thanks to paweljq.
  • A denial-of-service vulnerability has been fixed by replacing global regular expression replacement logic for comment removal with a new implementation. Thanks to Nariyoshi Chida of NTT Security Japan for pointing out the issue.

v2.7.0

Compare Source

  • Allows a more sensible set of default attributes on <img /> tags. Thanks to Zade Viggers.

v2.6.1

Compare Source

  • Fixes style filtering to retain !important when used.
  • Fixed trailing text bug on transformTags options that was reported on issue #​506. Thanks to Alex Rantos.

v2.6.0

Compare Source

  • Support for regular expressions in the allowedClasses option. Thanks to Alex Rantos.

v2.5.3

Compare Source

  • Fixed bug introduced by klona 2.0.5, by removing klona entirely.

v2.5.2

Compare Source

  • Nullish HTML input now returns an empty string. Nullish value may be explicit null, undefined or implicit undefined when value is not provided. Thanks to Artem Kostiuk for the contribution.
  • Documented that all text content is escaped. Thanks to Siddharth Singh.

v2.5.1

Compare Source

  • The allowedScriptHostnames and allowedScriptDomains options now implicitly purge the inline content of all script tags, not just those with src attributes. This behavior was already strongly implied by the fact that they purged it in the case where a src attribute was actually present, and is necessary for the feature to provide any real security. Thanks to Grigorii Duca for pointing out the issue.

v2.5.0

Compare Source

  • New allowedScriptHostnames option, it enables you to specify which hostnames are allowed in a script tag.
  • New allowedScriptDomains option, it enables you to specify which domains are allowed in a script tag. Thank you to Yorick Girard for this and the allowedScriptHostnames contribution.
  • Updates whitelist to allowlist.

v2.4.0

Compare Source

  • Added support for class names with wildcards in allowedClasses. Thanks to zhangbenber for the contribution.

v2.3.3

Compare Source

  • Security fix: allowedSchemes and related options did not properly block schemes containing a hyphen, plus sign, period or digit, such as ms-calculator:. Thanks to Lukas Euler for pointing out the issue.
  • Added a security note about the known risks associated with using the parser option, especially decodeEntities: false. See the documentation.

v2.3.2

Compare Source

  • Additional fixes for iframe validation exploits. Prevent exploits based on browsers' tolerance of the use of "" rather than "/" and the presence of whitespace at this point in the URL. Thanks to Ron Masas of Checkmarx for pointing out the issue and writing unit tests.
  • Updates README yarn add syntax. Thanks to Tagir Khadshiev for the contribution.

v2.3.1

Compare Source

  • Uses the standard WHATWG URL parser to stop IDNA (Internationalized Domain Name) attacks on the iframe hostname validator. Thanks to Ron Masas of Checkmarx for pointing out the issue and suggesting the use of the WHATWG parser.

v2.3.0

Compare Source

  • Upgrades htmlparser2 to new major version ^6.0.0. Thanks to Bogdan Chadkin for the contribution.

v2.2.0

Compare Source

  • Adds a note to the README about Typescript support (or the lack-thereof).
  • Adds tel to the default allowedSchemes. Thanks to Arne Herbots for this contribution.

v2.1.2

Compare Source

  • Fixes typos and inconsistencies in the README. Thanks to Eric Lefevre-Ardant for this contribution.

v2.1.1

Compare Source

  • Fixes a bug when using allowedClasses with an '*' wildcard selector. Thanks to Clemens Damke for this contribution.
  • Updates mocha to 7.x to resolve security warnings.

v2.1.0

Compare Source

  • sup added to the default allowed tags list. Thanks to Julian Lam for the contribution.
  • Updates default allowedTags README documentation. Thanks to Marco Arduini for the contribution.

v2.0.0

Compare Source

  • nestingLimit option added.
  • Updates ESLint config package and fixes warnings.
  • Upgrade is-plain-object package with named export. Thanks to Bogdan Chadkin for the contribution.
  • Upgrade postcss package and drop Node 11 and Node 13 support (enforced by postcss).
Backwards compatibility breaks:
  • There is no build. You should no longer directly link to a sanitize-html file directly in the browser as it is using modern Javascript that is not fully supported by all major browsers (depending on your definition). You should now include sanitize-html in your project build for this purpose if you have one.
  • On the server side, Node.js 10 or higher is required.
  • The default allowedTags array was updated significantly. This mostly added HTML tags to be more comprehensive by default. You should review your projects and consider the allowedTags defaults if you are not already overriding them.

v1.27.5

Compare Source

  • Updates README to include ES modules syntax.

v1.27.4

Compare Source

  • Fixes an IE11 regression from using Array.prototype.includes, replacing it with Array.prototype.indexOf.

v1.27.3

Compare Source

  • Fixes a bug when using transformTags with out textFilter. Thanks to Andrzej Porebski for the help with a failing test.

v1.27.2

Compare Source

  • Fixes CHANGELOG links. Thanks to Alex Mayer for the contribution.
  • Replaces srcset with parse-srcset. Thanks to Massimiliano Mirra for the contribution.

v1.27.1

Compare Source

  • Removes the unused chalk dependency.
  • Adds configuration for a Github stale bot.
  • Replace xtend package with native Object.assign.

v1.27.0

Compare Source

  • Adds the allowedIframeDomains option. This works similar to allowedIframeHostnames, where you would set it to an array of web domains. It would then permit any hostname on those domains to be used in iframe src attributes. Thanks to Stanislav Kravchenko for the contribution.

v1.26.0

Compare Source

  • Adds the option element to the default nonTextTagsArray of tags with contents that aren't meant to be displayed visually as text. This can be overridden with the nonTextTags option.

v1.25.0

Compare Source

  • Adds enforceHtmlBoundary option to process code bounded by the html tag, discarding any code outside of those tags.
  • Migrates to the main lodash package from the per method packages since they are deprecated and cause code duplication. Thanks to Merceyz for the contribution.
  • Adds a warning when style and script tags are allowed, as they are inherently vulnerable to being used in XSS attacks. That warning can be disabled by including the option allowVulnerableTags: true so this choice is knowing and explicit.

v1.24.0

Compare Source

  • Fixes a bug where self-closing tags resulted in deletion with disallowedTagsMode: 'escape' set. Thanks to Thiago Negri for the contribution.
  • Adds abbr to the default allowedTags for better accessibility support. Thanks to Will Farrell for the contribution.
  • Adds a mediaChildren property to the frame object in custom filters. This allows you to check for links or other parent tags that contain self-contained media to prevent collapse, regardless of whether there is also text inside. Thanks to axdg for the initial implementation and Marco Arduini for a failing test contribution.

v1.23.0

Compare Source

  • Adds eslint configuration and adds eslint to test script.
  • Sets sideEffects: false on package.json to allow module bundlers like webpack tree-shake this module and all the dependencies from client build. Thanks to Egor Voronov for the contribution.
  • Adds the tagName (HTML element name) as a second parameter passed to textFilter. Thanks to Slava for the contribution.

v1.22.1

Compare Source

ncreases the patch version of lodash.mergewith to enforce an audit fix.

v1.22.0

Compare Source

bumped htmlparser2 dependency to the 4.x series. This fixes longstanding bugs and should cause no bc breaks for this module, since the only bc breaks upstream are in regard to features we don't expose in this module.

v1.21.1

Compare Source

fixed issue with bad main setting in package.json that broke 1.21.0.

v1.21.0

Compare Source

new disallowedTagsMode option can be set to escape to escape disallowed tags rather than discarding them. Any subtags are handled as usual. If you want to recursively escape them too, you can set disallowedTagsMode to recursiveEscape. Thanks to Yehonatan Zecharia for this contribution.

v1.20.1

Compare Source

Fix failing tests, add CircleCI config

v1.20.0

Compare Source

reduced size of npm package via the files key; we only need to publish what's in dist. Thanks to Steven. There should be zero impact on behavior, minor version bump is precautionary.

v1.19.3

Compare Source

reverted to postcss due to a reported issue with css-tree that might or might not have XSS implications.

v1.19.2

Compare Source

  • Switched out the heavy postcss dependency for the lightweight css-tree module. No API changes. Thanks to Justin Braithwaite.
  • Various doc updates. Thanks to Pulkit Aggarwal and Cody Robertson.

v1.19.1

Compare Source

  • " characters are now entity-escaped only when they appear in attribute values, reducing the verbosity of the resulting markup.

  • Fixed a regression introduced in version 1.18.5 in the handling of markup that looks similar to a valid entity, but isn't. The bogus entity was passed through intact, i.e. &0; did not become &amp;0; as it should have. This fix has been made for the default parser settings only. There is no fix yet for those who wish to enable decodeEntities: false. That will require improving the alternative encoder in the escapeHtml function to only pass 100% valid entities.

For those using the default parser settings this bug is fixed. Read on if you are using alternative parser settings.

When decodeEntities: true is in effect (the default), this is not a problem because we only have to encode & < > " and we always encode those things.

There is currently a commented-out test which verifies one example of the problem when decodeEntities is false. However a correct implementation would need to not only pass that simple example but correctly escape all invalid entities, and not escape those that are valid.

v1.19.0

Compare Source

  • New allowIframeRelativeUrls option. It defaults to true unless allowedIframeHostnames is present, in which case it defaults to false, for backwards compatibility with existing behavior in both cases; however you can now set the option explicitly to allow both certain hostnames and relative URLs. Thanks to Rick Martin.

v1.18.5

Compare Source

  • Stop double encoding ampersands on HTML entities. Thanks to Will Gibson.

v1.18.4

Compare Source

  • Removed incorrect browser key, restoring frontend build. Thanks to Felix Becker.

v1.18.3

Compare Source

  • iframe is an allowed tag by default, to better facilitate typical use cases and the use of the allowedIframeHostnames option.
  • Documentation improvements.
  • More browser packaging improvements.
  • Protocol-relative URLs are properly supported for iframe tags.

v1.18.2

Compare Source

  • Travis tests passing.
  • Fixed another case issue — and instituted Travis CI testing so this doesn't happen again. Sorry for the hassle.

v1.18.1

Compare Source

  • A file was required with incorrect case, breaking the library on case sensitive filesystems such as Linux. Fixed.

v1.18.0

Compare Source

  • The new allowedSchemesAppliedToAttributes option. This determines which attributes are validated as URLs, replacing the old hardcoded list of src and href only. The default list now includes cite. Thanks to ml-dublin for this contribution.
  • It is now easy to configure a specific list of allowed values for an attribute. When configuring allowedAttributes, rather than listing an attribute name, simply list an object with an attribute name property and an allowed values array property. You can also add multiple: true to allow multiple space-separated allowed values in the attribute, otherwise the attribute must match one and only one of the allowed values. Thanks again to ml-dublin for this contribution.
  • Fixed a bug in the npm test procedure.

v1.17.0

Compare Source

The new allowedIframeHostnames option. If present, this must be an array, and only iframe src URLs hostnames (complete hostnames; domain name matches are not enough) that appear on this list are allowed. You must also configure hostname as an allowed attribute for iframe. Thanks to Ryan Verys for this contribution.

v1.16.3

Compare Source

Don't throw away the browserified versions before publishing them. prepare is not a good place to make clean, it runs after prepublish.

v1.16.2

Compare Source

sanitize-html is now compiled with babel. An npm prepublish script takes care of this at npm publish time, so the latest code should always be compiled to operate all the way back to ES5 browsers and earlier versions of Node. Thanks to Ayushya Jaiswal.

Please note that running sanitize-html in the browser is usually a security hole. Are you trusting the browser? Anyone could bypass that using the network panel. Sanitization is almost always best done on servers and that is the primary use case for this module.

v1.16.1

Compare Source

changelog formatting only.

v1.16.0

Compare Source

support for sanitizing inline CSS styles, by specifying the allowed attributes and a regular expression for each. Thanks to Cameron Will and Michael Loschiavo.

v1.15.0

Compare Source

if configured as an allowed attribute (not the default), check for naughty URLs in srcset attributes. Thanks to Mike Samuel for the nudge to do this and to Sindre Sorhus for the srcset module.

v1.14.3

Compare Source

inadvertent removal of lodash regexp quote dependency in 1.14.2 has been corrected.

v1.14.2

Compare Source

protocol-relative URL detection must spot URLs starting with \\ rather than // due to ages-old tolerance features of web browsers, intended for sleepy Windows developers. Thanks to Martin Bajanik.

v1.14.1

Compare Source

documented allowProtocolRelative option. No code changes from 1.14.0, released a few moments ago.

v1.14.0

Compare Source

the new allowProtocolRelative option, which is set to true by default, allows you to decline to accept URLs that start with // and thus point to a different host using the current protocol. If you do not want to permit this, set this option to false. This is fully backwards compatible because the default behavior is to allow them. Thanks to Luke Bernard.

v1.13.0

Compare Source

transformTags can now add text to an element that initially had none. Thanks to Dushyant Singh.

v1.12.0

Compare Source

option to build for browser-side use. Thanks to Michael Blum.

v1.11.4

Compare Source

fixed crash when __proto__ is a tag name. Now using a safe check for the existence of properties in all cases. Thanks to Andrew Krasichkov.

Fixed XSS attack vector via textarea tags (when explicitly allowed). Decided that script (obviously) and style (due to its own XSS vectors) cannot realistically be afforded any XSS protection if allowed, unless we add a full CSS parser. Thanks again to Andrew Krasichkov.

v1.11.3

Compare Source

bumped htmlparser2 version to address crashing bug in older version. Thanks to e-jigsaw.

v1.11.2

Compare Source

fixed README typo that interfered with readability due to markdown issues. No code changes. Thanks to Mikael Korpela. Also improved code block highlighting in README. Thanks to Alex Siman.

v1.11.1

Compare Source

fixed a regression introduced in 1.11.0 which caused the closing tag of the parent of a textarea tag to be lost. Thanks to Stefano Sala, who contributed the missing test.

v1.11.0

Compare Source

added the nonTextTags option, with tests.

v1.10.1

Compare Source

documentation cleanup. No code changes. Thanks to Rex Schrader.

v1.10.0

Compare Source

allowedAttributes now allows you to allow attributes for all tags by specifying * as the tag name. Thanks to Zdravko Georgiev.

v1.9.0

Compare Source

parser option allows options to be passed directly to htmlparser. Thanks to Danny Scott.

v1.8.0

Compare Source

  • transformTags now accepts the * wildcard to transform all tags. Thanks to Jamy Timmermans.

  • Text that has been modified by transformTags is then passed through textFilter. Thanks to Pavlo Yurichuk.

  • Content inside textarea is discarded if textarea is not allowed. I don't know why it took me this long to see that this is just common sense. Thanks to David Frank.

v1.7.2

Compare Source

removed array-includes dependency in favor of indexOf, which is a little more verbose but slightly faster and doesn't require a shim. Thanks again to Joseph Dykstra.

v1.7.1

Compare Source

removed lodash dependency, adding lighter dependencies and polyfills in its place. Thanks to Joseph Dykstra.

v1.7.0

Compare Source

introduced allowedSchemesByTag option. Thanks to Cameron Will.

v1.6.1

Compare Source

the string 'undefined' (as opposed to undefined) is perfectly valid text and shouldn't be expressly converted to the empty string.

v1.6.0

Compare Source

added textFilter option. Thanks to Csaba Palfi.

v1.5.3

Compare Source

do not escape special characters inside a script or style element, if they are allowed. This is consistent with the way browsers parse them; nothing closes them except the appropriate closing tag for the entire element. Of course, this only comes into play if you actually choose to allow those tags. Thanks to aletorrado.

v1.5.2

Compare Source

guard checks for allowed attributes correctly to avoid an undefined property error. Thanks to Zeke.

v1.5.1

Compare Source

updated to htmlparser2 1.8.x. Started using the decodeEntities option, which allows us to pass our filter evasion tests without the need to recursively invoke the filter.

v1.5.0

Compare Source

support for * wildcards in allowedAttributes. With tests. Thanks to Calvin Montgomery.

v1.4.3

invokes itself recursively until the markup stops changing to guard against this issue. Bump to htmlparser2 version 3.7.x.


  • If you want to rebase/retry this PR, check this box

@mend-for-github-com mend-for-github-com bot added the security fix Security fix generated by Mend label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security fix Security fix generated by Mend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants