Fix unknown sensors #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my computer `sensors` wive me a list of sensors but with names that the sysinfo library doesn't recognize, so I decided to make a fix for it. if the sensor isn't found in sysinfo, instead of giving an error everytime, only throw 1 error and a list of found sensors (on my computer it was `nct6797 CPUTIN` which `sensors` did not lists under that name)
When the specified network interface isn't found, it gives the user a list of all the recognized interfaces
not-jan
reviewed
Apr 23, 2023
src/providers/sysinfo.rs
Outdated
| warn!("couldn't find sensor `{}`", self.sensor_name); | ||
| Ok(()) | ||
| })?; | ||
| }); |
There was a problem hiding this comment.
This result is unused. That could lead to it having no effect. Can you fix that? You can use cargo clippy to find mistakes like these.
There was a problem hiding this comment.
Yes I will try to fix that, it's my first time in rust so there's a lot that I have to learn
src/providers/sysinfo.rs
Outdated
| ).is_none(){ | ||
| warn!("Couldn't find network interface `{}`", net_interface_name); | ||
| info!("Instead, found those interfaces:"); | ||
| for (interface_name, _unused) in sys.networks() { |
There was a problem hiding this comment.
Better would be for (interface_name, _) in sys.networks()
|
I think I modified the code to something you could like, please let me know if there are other things that bother you |
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My computer is weird, my system doesn't use eth0 for the ethernet and the temperature sensor given by the command
sensorisn't recognized by rust.So I edited the code to give the user a list of available sensor/interface when the default one doesn't works.