Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate Shiwei Zhang (@shizhMSFT) as a Notary Project Org maintainer #56

Closed
yizha1 opened this issue Dec 8, 2023 · 11 comments
Closed

Comments

@yizha1
Copy link
Contributor

yizha1 commented Dec 8, 2023

At the Notary Project community meeting held on December 4, 2023, the community discussed and agreed on nominating new Notary Project Org maintainers from subproject maintainers according to the governance guide.

I would like to nominate Shiwei Zhang (@shizhMSFT) as a Notary Project Org maintainer. Shiwei Zhang (@shizhMSFT) has been a Notary Project subproject maintainer for subprojects: specifications, notation, notation-go, notation-core-go, notation-action and notation-plugin-framework-go. He has made significant and unique contributions to the Notary Project since joining the community.

From routine work perspective, Shiwei Zhang (@shizhMSFT) has demonstrated a high meeting participation rate considering the time zone and has contributed significantly to quality control by reviewing PRs and providing comments on issues. The following table shows his contributions to the Notary Project sub-projects in the last 12 months. He has made amazing 681 PR comments, almost 2 comments on PR per day.

Name (GitHub ID) PR Issue PR comments Issue comments Meetings
Shiwei Zhang (@shizhMSFT) 8 20 681 168 40/78

Not only the number of comments, if you take a deeper look at the comments that Shiwei Zhang (@shizhMSFT) made, those are very insightful and deep thought comments, see an example notaryproject/notation#601 (comment). For maintainers and contributors, I believe you all have the feeling that if your PRs are reviewed and approved by Shiwei Zhang (@shizhMSFT), it means high quality.

Shiwei Zhang (@shizhMSFT) is a security expert. He led the design and implementation of the Notary Project COSE signature in notation-core-go library and is the main contributor to the go-cose library, which is used by the notation-core-go library. He has also demonstrated his expertise in the recent security audit and has received credits for several security advisories. Not to mention the latest notation threat model was created with his guidance.

Last but not least, Shiwei Zhang (@shizhMSFT) participated in KubeCon China (Due to the pandemic, this conference has not been held for several years) and promote Notary Project solutions. He answered questions, did demos for folks who were interested in the Notary Project at the project booth. The following table shows more information about his activities in the last 12 months:

Name (GitHub ID) Activities
Shiwei Zhang (@shizhMSFT) KubeCon China 2023 (project booth), Notation Security audit 2023

I believe that Shiwei Zhang (@shizhMSFT)'s experience and security expertise will be an asset to the Notary Project, and I am confident that he will continue to make valuable contributions to the community.

The data shown in above tables is copied from source #54

Please comment "+1" to vote for Shiwei Zhang (@shizhMSFT), according to the governance guide and agreement on community meeting, we need two votes out of three from current org maintainers.
Tag Org maintainers: @NiazFK @justincormack @SteveLasker

/cc other maintainers: @cipherboy @OliverShang @FeynmanZhou @HuKeping @JeyJeyGao @duffney @gokarnm @mnm678 @priteshbandi @Two-Hearts @rgnote @iamsamirzon @toddysm @shizhMSFT @vaninrao10 @yizha1 @zr-msft

@Two-Hearts
Copy link

+1

2 similar comments
@justincormack
Copy link

+1

@FeynmanZhou
Copy link
Member

+1

@HuKeping
Copy link

HuKeping commented Dec 8, 2023 via email

@toddysm
Copy link
Contributor

toddysm commented Dec 8, 2023

+1

4 similar comments
@SteveLasker
Copy link
Contributor

+1

@OliverShang
Copy link

+1

@priteshbandi
Copy link

+1

@NiazFK
Copy link

NiazFK commented Jan 4, 2024

+1

@vaninrao10
Copy link

+1 as per the discussion in the meeting.

@toddysm
Copy link
Contributor

toddysm commented Jan 4, 2024

As per discussion in this morning's community discussion and based on the votes for @shizhMSFT we decided to move forward with adding him to the Org maintainers. I will go ahead and create the necessary PRs to update the relevant MAINTAINERS and CODEOWNERS files

toddysm added a commit that referenced this issue Jan 11, 2024
Addressing #55 #56 and #57

---------

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm toddysm closed this as completed Jan 13, 2024
toddysm added a commit to notaryproject/notaryproject.dev that referenced this issue Jan 14, 2024
toddysm added a commit to notaryproject/notation-go that referenced this issue Jan 14, 2024
toddysm added a commit to notaryproject/notation that referenced this issue Jan 14, 2024
toddysm added a commit to notaryproject/meeting-notes that referenced this issue Jan 14, 2024
toddysm added a commit to notaryproject/roadmap that referenced this issue Jan 14, 2024
toddysm added a commit to notaryproject/notation-core-go that referenced this issue Jan 14, 2024
priteshbandi pushed a commit to notaryproject/notation-plugin-framework-go that referenced this issue Jan 25, 2024
rgnote pushed a commit to rgnote/notation that referenced this issue Mar 8, 2024
rgnote pushed a commit to rgnote/notation that referenced this issue Mar 8, 2024
Addressing notaryproject/.github#55
notaryproject/.github#56 and
notaryproject/.github#57

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: rgnote <5878554+rgnote@users.noreply.github.com>
OliverShang pushed a commit to notaryproject/notation-hashicorp-vault that referenced this issue Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests