Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leaf certificate validation #202

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Conversation

Two-Hearts
Copy link
Contributor

Resolves #201

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (2bc927b) to head (6385b9a).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   89.32%   89.87%   +0.54%     
==========================================
  Files          21       23       +2     
  Lines        1724     1590     -134     
==========================================
- Hits         1540     1429     -111     
+ Misses        149      120      -29     
- Partials       35       41       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 356b30e into notaryproject:main Apr 18, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the fix branch April 18, 2024 01:02
@JeyJeyGao JeyJeyGao mentioned this pull request May 29, 2024
6 tasks
@Two-Hearts Two-Hearts mentioned this pull request Jul 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: leaf certificate key usage should not forbid ContentCommitment
4 participants